-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for legacy Python 2 #1237
Conversation
This is awesome! We can't merge this until after v0.18 is released though, and I'm really concerned that this PR will go very stale in that time. Hopefully you were able to run this through 2to3 or something and it was all autogenerated? Do you want to keep this open (in the knowledge it is likely to go stale), or shall we close and re-open once we have cut v0.18? The latter is my preference, but I'm open to either approaches. |
Most of the changes (in the second and third commits) were made using a tool (pyupgrade), so it'll be easy to redo this after 0.18 is out. I'd probably prefer to keep it open so it's visible and not forgotten, but don't have a strong preference. Do whichever fits you feel is best for this project :) |
In which case I will go ahead and close this. We have the issue to track the problem, and it links directly to this PR so we can easily enough find this again. Thanks again for doing this - it was useful to see the kinds of things we are going to be able to remove once py2 is dropped, not to mention all of the features we can start to benefit from. |
Heh, will do, thanks! |
Please see PR #1540. |
Rationale
Fix #1186.
Implications
People using Python 2 will not be able to use the most recent release of cartopy.
The Python 2 EOL is coming up on 2020-01-01 and many other projects have pledged to drop support on or before that date: http://python3statement.org
Here's the pip installs for cartopy from PyPI for last month, showing Python 2 use is fairly low:
Source:
pypistats python_minor --last-month cartopy
The addition of
python_requires
means, with modern pip and setuptools, users will get the last cartopy which did support Python 2.