Dedent some gridline code #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of `_draw_gridliner` is within a single `if`, which can be inverted to drop an indent level. Additionally, most of the rest is within a double-for loop, which can be combined to reduce indent another level. This reduces several weird wrapping issues.
QuLogic
force-pushed
the
dedent-gridlines
branch
from
ff9d4b6
to
c4f2585
Compare
greglucas
approved these changes
Sep 16, 2021
|
Good suggestion on ignoring the whitespace changes, that did make it much more straightforward to view the diff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Most of
_draw_gridlineris within a singleif, which can be inverted to drop an indent level. Additionally, most of the rest is within a double-for loop, which can be combined to reduce indent another level.Implications
This reduces several weird wrapping issues.
I do have some followup changes, but I thought I'd open this up separately for easier review. It's probably best to look at the diff with whitespace changes ignored.