Cache transformer crs for v0.20.x #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
approved these changes
Nov 13, 2021
greglucas
force-pushed
the
cache-transformer-crs-v0.20
branch
from
34f7422
to
b859ed5
Compare
This adds a cache mechanism to creating Transformer objects, which can be slow when called frequently. Additionally, this requires adding attributes to the Mercator creation as the x/y limits are created in the initializer which uses the cache/hash function.
greglucas
force-pushed
the
cache-transformer-crs-v0.20
branch
from
b859ed5
to
457f4b9
Compare
dopplershift
approved these changes
Nov 14, 2021
This milestone was closed with 0.20.0; this should go on a new milestone for 0.20.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1918, but pointing at v0.20.x.
I think this would be good to get in soon to contribute to a patch release as it is fixing something that I missed in the cache the first go around and should only improve performance for users.