Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete validity checking in GDT 3.10 #188

Open
pp-mo opened this issue Feb 12, 2020 · 1 comment · May be fixed by #446
Open

Incomplete validity checking in GDT 3.10 #188

pp-mo opened this issue Feb 12, 2020 · 1 comment · May be fixed by #446
Assignees
@pp-mo @trexfeathers
Labels
Experience-needed: Low T-Shirt: Small Type: Bug Type: Technical Debt known issues left over from incomplete work

Comments

@pp-mo
Copy link
Member

pp-mo commented Feb 12, 2020

The translation routine for gdt 3.10 (mercator grids) does not check all termplate parameters.
Specifically, it doesn't check the scanningMode, nor any of the following parameters at the end of the template : "Orientation of the grid", "longitudinal direction grid length", "latitudinal direction grid length"
(I haven't checked what the actual key names of those in ecCodes would be)

For comparison, the translation routine for gdt 3.12 (transverse mercator grids) does check the scanningMode parameter, and errors if contains unsupported settings.
@pp-mo pp-mo added T-Shirt: Small Type: Bug Type: Technical Debt known issues left over from incomplete work labels Feb 12, 2020
@pp-mo
Copy link
Member Author

pp-mo commented Feb 12, 2020 •
edited

NOTE
I might be wrong about this. I think at least some of it is handled by the call to _calculate_proj_coords_from_grid_lengths.
I still think that 'orientationOfTheGrid' is going unchecked though.

@pp-mo pp-mo self-assigned this Apr 19, 2024
@trexfeathers trexfeathers linked a pull request Apr 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pp-mo pp-mo

@trexfeathers trexfeathers

Labels
Experience-needed: Low T-Shirt: Small Type: Bug Type: Technical Debt known issues left over from incomplete work
Projects
🚴 Peloton
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle missing keys for GDT10 Mercator trexfeathers/iris-grib
2 participants
@pp-mo @trexfeathers