Handle missing keys for GDT10 Mercator #446
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
approved these changes
Apr 19, 2024
| @@ -776,10 +776,35 @@ def grid_definition_template_10(section, metadata): | |||
| # intersects the Earth | |||
| standard_parallel = section["LaD"] * _GRID_ACCURACY_IN_DEGREES | |||
|
|
|||
| if "orientationOfTheGrid" in section and not np.isclose( | |||
There was a problem hiding this comment.
What's the need for "if ... in section" here -- have I misunderstood something ?
By my understanding, if gdt is 10 then this key should always be present, though it may have missing/None value ?
There was a problem hiding this comment.
I thought the same, but some of my tests failed so I had to add 44437da . Of course I suppose there is a chance that it is present but also None...
trexfeathers
commented
Apr 22, 2024
Comment on lines
+795
to
+798
| if not ( | ||
| np.isclose(section["longitudeOfLastGridPoint"], final_x_point) | ||
| and np.isclose(section["latitudeOfLastGridPoint"], final_y_point) | ||
| ): |
There was a problem hiding this comment.
Experiments so far have produced many cases where this block is true, which makes me worried I need an extra factor in here like scaling or units or something. That's why I changed the PR back to draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188