Add support for reg 92.1.8 where lon increment not given #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @m1dr, we had a CI problem that's now been fixed, would you mind rebasing on master? The CI tests should then run properly. |
m1dr
force-pushed
the
handle_longitude_mod
branch
from
f854af6
to
01ef303
Compare
|
Hi @jamesp, thanks for the heads up. Saw they'd failed for reasons unrelated to my changes but wasn't sure who to contact. |
|
This is great! Thanks @m1dr! I'm going to merge, and then this will be available in the 0.17 release. We're hoping to get that out in the next couple of months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per regulation 92.1.8, longitudes are limited to the range 0 to 360 degrees. This PR adds support for calculating
iDirectionIncrementwhen not given (i.e.resolutionAndComponentFlagsbit 3 is 0) wherelongitudeOfFirstGridPointandlongitudeOfLastGridPointspan the prime meridian in GDTs 0 and 40 and siblings.