Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide masked/unmasked meta for calls to 'as_lazy_data' #463

Merged
merged 3 commits into from
May 2, 2024

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented May 1, 2024

iris._lazy_data.as_lazy_data has changed : See iris#5801.

Current failing tests against iris latest,
e.g. see https://github.com/SciTools/iris-grib/actions/runs/8892392519/job/24416350591

@pp-mo
Copy link
Member Author

pp-mo commented May 1, 2024

NOTE: this is rather tiresome as, at present the new code only works with the new iris version.

Effectively, iris._lazy_data.as_lazy_data was not a private routine which we could freely change,
since iris-grib uses it !

So, before SciTools/iris#5801 it had no 'meta' keyword,
but now after that it requires one.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 89.16%. Comparing base (fea1607) to head (29ae999).
Report is 3 commits behind head on main.

Files Patch % Lines
src/iris_grib/__init__.py 66.66% 6 Missing and 1 partial ⚠️
src/iris_grib/message.py 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   89.51%   89.16%   -0.35%     
==========================================
  Files           8        8              
  Lines        2450     2474      +24     
  Branches      416      418       +2     
==========================================
+ Hits         2193     2206      +13     
- Misses        161      170       +9     
- Partials       96       98       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo pp-mo marked this pull request as ready for review May 1, 2024 12:22
@bjlittle bjlittle self-assigned this May 1, 2024
@bjlittle bjlittle self-requested a review May 1, 2024 13:47
src/iris_grib/__init__.py Show resolved Hide resolved
@bjlittle bjlittle force-pushed the irisdaskfix_testbitmap_trial branch from 29ae999 to db43d56 Compare May 2, 2024 22:28
@bjlittle bjlittle mentioned this pull request May 2, 2024
@bjlittle bjlittle merged commit 2732030 into SciTools:main May 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants