grib save : minor update #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing until tests have been added. |
| mock_set_long.assert_any_call(grib, "typeOfSecondFixedSurface", -1) | ||
| mock_set_long.assert_any_call(grib, "scaleFactorOfSecondFixedSurface", 255) | ||
| mock_set_long.assert_any_call(grib, "scaledValueOfSecondFixedSurface", -1) | ||
|
|
There was a problem hiding this comment.
Lovely use of mocking. Would it be worth while adding test coverage for a AuxCoord with bounds?
There was a problem hiding this comment.
Definitely, yes, but I thought that was out of scope for a support issue, where we're supposed to be providing evolutionary steps not full feature developments. I don't need bounds so I didn't think I was supposed to address them here, as it would needlessly delay the support. Not certain about this though!
I've requested a support milestone, which might help clarify this in the future.
larsbarring
added a commit
to larsbarring/iris
that referenced
this pull request
May 8, 2023
cf-convention/discuss#229 Standard names: hard to spot "typo" in `surface_upward_mass_flux_of_methane_due_to_emission_from_fires`
larsbarring
added a commit
to larsbarring/iris
that referenced
this pull request
May 10, 2023
cf-convention/discuss#229 Standard names: hard to spot "typo" in `surface_upward_mass_flux_of_methane_due_to_emission_from_fires`
larsbarring
added a commit
to larsbarring/iris
that referenced
this pull request
May 15, 2023
cf-convention/discuss#229 Standard names: hard to spot "typo" in `surface_upward_mass_flux_of_methane_due_to_emission_from_fires`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes support a user who is converting NetCDF to GRIB2.