Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard names: hard to spot "typo" in surface_upward_mass_flux_of_methane_due_to_emission_from_fires #229

Closed
larsbarring opened this issue May 3, 2023 · 3 comments
Labels
add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor defect Error or typo in standard names or other controlled vocabulary standard name (added by template) Requests and discussions for standard names and other controlled vocabulary

Comments

@larsbarring
Copy link

larsbarring commented May 3, 2023

When trying to ingest the xml version of the new version 81 Standard name table into some python code, I found a difficult to spot "typo" in the description (linebreaks added for readability):

   <entry id="surface_upward_mass_flux_of_methane_due_to_emission_from_fires">
      <canonical_units>kg m-2 s-1</canonical_units>
      <grib></grib>
      <amip></amip>
      <description>Methane emitted from the surface, generated by biomass burning (fires). 
      Positive direction upwards.***ctrl-M*** The surface called &quot;surface&quot; means 
      the lower boundary of the atmosphere. &quot;Upward&quot; indicates a vector 
      component which is positive when directed upward (negative downward). In accordance 
      with common usage in geophysical disciplines, &quot;flux&quot; implies per unit area, 
      called &quot;flux density&quot; in physics. The chemical formula for methane
      is CH4. The mass is the total mass of the molecules. The specification of a physical 
      process by the phrase &quot;due_to_&quot; process means that the quantity named is a 
      single term in a sum of terms which together compose the general quantity named 
      by omitting the phrase. &quot;Emission&quot; means emission from a primary source 
      located anywhere within the atmosphere, including at the lower boundary (i.e. the surface 
      of the earth). &quot;Emission&quot; is a process entirely distinct from &quot; re-emission&quot; 
      which is used in some standard names. The term &quot;fires&quot; means all biomass fires, 
      whether naturally occurring or ignited by humans. The precise conditions under which fires 
      produce and consume methane can vary between models.</description>
   </entry>

where the "typo" is indicated by the ***ctrl-M*** in the second line of the description. This is the invisible control character carriage return (decimal value 13) that is ignored in the html display version of the xml table and generally difficult to spot by humans.

It would be helpful if the table could be updated to remove this rouge character.

Many thanks,
Lars

@larsbarring larsbarring added standard name (added by template) Requests and discussions for standard names and other controlled vocabulary add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor labels May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

Thank you for your proposal. These terms will be added to the cfeditor (http://cfeditor.ceda.ac.uk/proposals/1) shortly. Your proposal will then be reviewed and commented on by the community and Standard Names moderator.

@larsbarring larsbarring added the defect Error or typo in standard names or other controlled vocabulary label May 8, 2023
larsbarring added a commit to larsbarring/iris that referenced this issue May 8, 2023
cf-convention/discuss#229
Standard names: hard to spot "typo" in
`surface_upward_mass_flux_of_methane_due_to_emission_from_fires`
larsbarring added a commit to larsbarring/iris that referenced this issue May 10, 2023
cf-convention/discuss#229
Standard names: hard to spot "typo" in
`surface_upward_mass_flux_of_methane_due_to_emission_from_fires`
larsbarring added a commit to larsbarring/iris that referenced this issue May 15, 2023
cf-convention/discuss#229
Standard names: hard to spot "typo" in
`surface_upward_mass_flux_of_methane_due_to_emission_from_fires`
@japamment
Copy link
Member

Hi @larsbarring

Since this is a formatting error does not relate to content, I have fixed the typo (I think!) and reprocessed version 81 of the standard name table.

Please let me know if it is still causing any problems.

Best wishes,
Alison

@larsbarring
Copy link
Author

Hi Alison @japamment
Now it works 👍 Many thanks.

Best wishes,
Lars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor defect Error or typo in standard names or other controlled vocabulary standard name (added by template) Requests and discussions for standard names and other controlled vocabulary
Projects
None yet
Development

No branches or pull requests

2 participants