Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links and gallery test #4132

Closed
wants to merge 2 commits into from
Closed

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented May 13, 2021

馃殌 Pull Request

Description

Fixed a couple of broken links.


Consult Iris pull request check list

@rcomer rcomer added this to In progress in Iris v3.0.x via automation May 13, 2021
@bjlittle bjlittle self-assigned this May 13, 2021
@bjlittle
Copy link
Member

bjlittle commented May 13, 2021

@rcomer I restarted the timed-out cirrus-ci jobs. However, we're getting a gallery graphical test failure:

FAIL: test_plot_wind_speed (gallery_tests.test_plot_wind_speed.TestWindSpeed)

馃槩

@rcomer
Copy link
Member Author

rcomer commented May 13, 2021

@bjlittle I'm pretty sure the gallery tests are using an older matplotlib version (can't find a conda list). We removed the old hashes for that wind plot at #4112, because the old images didn't include some lake features that had been explicitly plotted. The test passes locally with an up-to-date environment 馃憤

@rcomer
Copy link
Member Author

rcomer commented May 13, 2021

Wind example in stable docs no lakes 馃憥
Wind example in dev docs lakes 馃憤

@rcomer
Copy link
Member Author

rcomer commented May 13, 2021

For #4059 (comment) I also ran the main tests locally under both py3.6 and py3.7. So I'm confident all is well.

@rcomer rcomer changed the title Fix broken links Fix broken links and gallery test May 13, 2021
@rcomer
Copy link
Member Author

rcomer commented May 13, 2021

@bjlittle please see additional commit to blacken those lake edges. Gallery tests now passing.

馃槑

@bjlittle
Copy link
Member

bjlittle commented May 14, 2021

@rcomer Clearly we're not going to get CI to work for py36 or py37 on v3.0.x due to known reasons... so I'm going to test your branch locally instead for both Python versions.

I'm happy to merge with CI failures, but local passes 馃憤

@rcomer
Copy link
Member Author

rcomer commented May 15, 2021

@bjlittle I think we'll need to pull in #4139 to get the tests passing with a fully up-to-date environment 馃槩

I'm on leave for the next week and can't promise to give this attention. Please feel free to do whatever you like with my branches to get v3.0.2 over the line.

This was referenced May 25, 2021
@bjlittle bjlittle moved this from In progress to Review in progress in Iris v3.0.x May 25, 2021
@rcomer
Copy link
Member Author

rcomer commented May 25, 2021

Superseded by #4154

@rcomer rcomer closed this May 25, 2021
Iris v3.0.x automation moved this from Review in progress to Done May 25, 2021
@rcomer rcomer deleted the fix-links branch May 25, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants