New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links and gallery test #4132
Conversation
@rcomer I restarted the timed-out cirrus-ci jobs. However, we're getting a gallery graphical test failure:
馃槩 |
@bjlittle I'm pretty sure the gallery tests are using an older matplotlib version (can't find a conda list). We removed the old hashes for that wind plot at #4112, because the old images didn't include some lake features that had been explicitly plotted. The test passes locally with an up-to-date environment 馃憤 |
Wind example in stable docs no lakes 馃憥 |
For #4059 (comment) I also ran the main tests locally under both py3.6 and py3.7. So I'm confident all is well. |
@bjlittle please see additional commit to blacken those lake edges. Gallery tests now passing. 馃槑 |
@rcomer Clearly we're not going to get CI to work for I'm happy to merge with CI failures, but local passes 馃憤 |
Superseded by #4154 |
馃殌 Pull Request
Description
Fixed a couple of broken links.
Consult Iris pull request check list