Suppress warning in animation test #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option might be to modify the |
@rcomer Did you want to give that a try instead? |
This reverts commit 414779e.
rcomer
force-pushed
the
suppress-animation-warning
branch
from
414779e
to
552764f
Compare
|
@bjlittle yeah, I was leaning towards that too. How's this? I can confirm that the warning is not thrown when I just run the one test module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Occasionally we get test failures because
assertWarnsfinds a warning about animation deletion when it is expecting something else, in tests that have nothing to do with animation. Running this single test module prior to this change shows that the warning is thrown here. I thought it might be worth suppressing it, but obviously I have no way to check whether it will cure the problem of interfering with other tests, as it only happens sporadically.Worth a try?
Consult Iris pull request check list