Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs page on filtering warnings #5509

Merged
merged 5 commits into from Sep 25, 2023
Merged

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Sep 21, 2023

πŸš€ Pull Request

Description

Closes #5473

βœ” Needs #5498 - I will rebase onto main once that is merged. The first new commit of this branch is 01ead3c

Click here to view the docs page


Consult Iris pull request check list

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Sep 21, 2023

EDIT: βœ” sorted 43c4649

πŸ€¦β€β™‚οΈ gonna have to rethink the doctest expected warnings! Can't have them pointing at my own path, nor anyone else's!

Expected:
    /net/home/h01/myeo/repos/iris/lib/iris/coord_systems.py:454: IrisUserWarning: Setting inverse_flattening does not affect other properties of the GeogCS object. To change other properties set them explicitly or create a new GeogCS instance.
      warnings.warn(wmsg, category=iris.exceptions.IrisUserWarning)
Got:
    /home/runner/work/iris/iris/lib/iris/coord_systems.py:454: IrisUserWarning: Setting inverse_flattening does not affect other properties of the GeogCS object. To change other properties set them explicitly or create a new GeogCS instance.
      warnings.warn(wmsg, category=iris.exceptions.IrisUserWarning)

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4f126a0) 89.41% compared to head (0266156) 89.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5509   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          89       89           
  Lines       22539    22539           
  Branches     5387     5387           
=======================================
  Hits        20154    20154           
  Misses       1639     1639           
  Partials      746      746           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@trexfeathers trexfeathers marked this pull request as ready for review September 22, 2023 10:54
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers Lovely, let's bank this. Great job πŸ’―

@bjlittle bjlittle merged commit d923f34 into SciTools:main Sep 25, 2023
17 checks passed
@trexfeathers
Copy link
Contributor Author

Thanks @bjlittle!

tkknight added a commit to tkknight/iris that referenced this pull request Oct 26, 2023
* upstream/main:
  moved latest warning banner logic to conf.py (SciTools#5508)
  updated layout of top navbar (SciTools#5505)
  Oblique and Rotated Mercator (SciTools#5548)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5549)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5527)
  Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540)
  nep29 drop table schedule numpy>1.21 (SciTools#5525)
  Updated environment lockfiles (SciTools#5545)
  Replaced `NotImplementedError` with `NotImplemented` (SciTools#5544)
  Gallery: show colour bar stealing space from multiple axes (SciTools#5537)
  Updated environment lockfiles (SciTools#5524)
  Set some memory benchmarks to on-demand to reduce noise. (SciTools#5481)
  updating docs and stale comment (SciTools#5522)
  Ensure removal of release candidate from What's New title. (SciTools#5526)
  Updated environment lockfiles (SciTools#5513)
  Docs page on filtering warnings (SciTools#5509)
  Replaced pkg_resources version parser with packager version parser. (SciTools#5511)
  Categorise warnings (SciTools#5498)
  Updated all np.product calls to np.prod (SciTools#5493)
@trexfeathers trexfeathers deleted the warnings_docs branch May 3, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to suppress warnings
2 participants