Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nep29 drop table schedule numpy>1.21 #5525

Merged
merged 2 commits into from Oct 18, 2023
Merged

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Oct 2, 2023

🚀 Pull Request

Description

The pull-request bumps the minimum numpy version to >1.21, according to the NEP29 Drop Schedule.


Consult Iris pull request check list

@bjlittle bjlittle changed the title nep29 drop table schedule numpy>1.12 nep29 drop table schedule numpy>1.21 Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e9c77c0) 89.41% compared to head (c84c2f8) 89.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5525   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          89       89           
  Lines       22539    22539           
  Branches     5387     5387           
=======================================
  Hits        20154    20154           
  Misses       1639     1639           
  Partials      746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcomer
Copy link
Member

rcomer commented Oct 9, 2023

If the next minor Iris release is not till February, as #5363 suggests, then we could go straight to >1.22.

@rcomer
Copy link
Member

rcomer commented Oct 10, 2023

This also needs a whatsnew entry 😉

@rcomer rcomer merged commit f459f15 into SciTools:main Oct 18, 2023
17 checks passed
@bjlittle
Copy link
Member Author

@rcomer Awesome, thanks 🍻

tkknight added a commit to tkknight/iris that referenced this pull request Oct 26, 2023
* upstream/main:
  moved latest warning banner logic to conf.py (SciTools#5508)
  updated layout of top navbar (SciTools#5505)
  Oblique and Rotated Mercator (SciTools#5548)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5549)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5527)
  Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540)
  nep29 drop table schedule numpy>1.21 (SciTools#5525)
  Updated environment lockfiles (SciTools#5545)
  Replaced `NotImplementedError` with `NotImplemented` (SciTools#5544)
  Gallery: show colour bar stealing space from multiple axes (SciTools#5537)
  Updated environment lockfiles (SciTools#5524)
  Set some memory benchmarks to on-demand to reduce noise. (SciTools#5481)
  updating docs and stale comment (SciTools#5522)
  Ensure removal of release candidate from What's New title. (SciTools#5526)
  Updated environment lockfiles (SciTools#5513)
  Docs page on filtering warnings (SciTools#5509)
  Replaced pkg_resources version parser with packager version parser. (SciTools#5511)
  Categorise warnings (SciTools#5498)
  Updated all np.product calls to np.prod (SciTools#5493)
HGWright added a commit to HGWright/iris that referenced this pull request Nov 17, 2023
* 'guess_coord' of github.com:HGWright/iris: (82 commits)
  [pre-commit.ci] auto fixes from pre-commit.com hooks
  [pre-commit.ci] pre-commit autoupdate (SciTools#5579)
  Relicense to from LGPL-3 to BSD-3 (SciTools#5577)
  Allow `add_season_year()` to optionally send spans backwards (SciTools#5573)
  Added xarray phrasebook doc page (SciTools#5564)
  fixed spacing (SciTools#5572)
  DOCS: Removed broken git links. (SciTools#5569)
  More sensible time axis and tick labels for 2D plots (SciTools#5561)
  removed now incorrect statement. (SciTools#5555)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5558)
  Exempt major release label from stalebot (SciTools#5559)
  updated link (SciTools#5556)
  Added whatsnew. (SciTools#5552)
  moved latest warning banner logic to conf.py (SciTools#5508)
  updated layout of top navbar (SciTools#5505)
  Oblique and Rotated Mercator (SciTools#5548)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5549)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5527)
  Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540)
  nep29 drop table schedule numpy>1.21 (SciTools#5525)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants