Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added phrasebook #5564

Merged
merged 1 commit into from Nov 9, 2023
Merged

added phrasebook #5564

merged 1 commit into from Nov 9, 2023

Conversation

ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Nov 2, 2023

Closes #5091.

Created a phrasebook for comparing similar packages.

This is intended as a starting basis, with space for more to be added at a later date.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dc2dd9) 89.44% compared to head (bffe09f) 89.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5564   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          89       89           
  Lines       22583    22583           
  Branches     5386     5386           
=======================================
  Hits        20199    20199           
  Misses       1638     1638           
  Partials      746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, Just a couple notes here, mostly I think it's worth being a bit more precise about the differences between Iris and xarray.

Also, there ought to be a link to this documentation page somewhere here https://github.com/SciTools/iris/blob/main/docs/src/community/index.rst and also perhaps here https://github.com/SciTools/iris/blob/main/docs/src/community/iris_xarray.rst .

docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/index.rst Show resolved Hide resolved
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor capitalisation changes and this is looking good.

docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
docs/src/community/phrasebook.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good job!

@stephenworsley stephenworsley merged commit ce813ff into SciTools:main Nov 9, 2023
17 checks passed
HGWright added a commit to HGWright/iris that referenced this pull request Nov 17, 2023
* 'guess_coord' of github.com:HGWright/iris: (82 commits)
  [pre-commit.ci] auto fixes from pre-commit.com hooks
  [pre-commit.ci] pre-commit autoupdate (SciTools#5579)
  Relicense to from LGPL-3 to BSD-3 (SciTools#5577)
  Allow `add_season_year()` to optionally send spans backwards (SciTools#5573)
  Added xarray phrasebook doc page (SciTools#5564)
  fixed spacing (SciTools#5572)
  DOCS: Removed broken git links. (SciTools#5569)
  More sensible time axis and tick labels for 2D plots (SciTools#5561)
  removed now incorrect statement. (SciTools#5555)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5558)
  Exempt major release label from stalebot (SciTools#5559)
  updated link (SciTools#5556)
  Added whatsnew. (SciTools#5552)
  moved latest warning banner logic to conf.py (SciTools#5508)
  updated layout of top navbar (SciTools#5505)
  Oblique and Rotated Mercator (SciTools#5548)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5549)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5527)
  Bump scitools/workflows from 2023.09.1 to 2023.10.0 (SciTools#5540)
  nep29 drop table schedule numpy>1.21 (SciTools#5525)
  ...
@ESadek-MO ESadek-MO deleted the phrasebook branch November 23, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create phrase book for xarray to/from iris
2 participants