Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whatsnew entries for #5610 and #5621 #5626

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

bouweandela
Copy link
Member

🚀 Pull Request

Description

Add whatsnew entries for #5610 and #5621 because I forgot to do it in the pull request.


Consult Iris pull request check list

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba57f28) 89.69% compared to head (6e54c35) 89.69%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5626   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review December 12, 2023 09:34
@bjlittle
Copy link
Member

bjlittle commented Dec 12, 2023

@bouweandela Fancy doing a rebase now that #5631 has landed ?

That'll fix the twitter URL linkcheck failure.

Thanks 👍

@bouweandela
Copy link
Member Author

Done!

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bouweandela Brilliant, thanks 🍻

@bjlittle bjlittle merged commit 2da5de9 into SciTools:main Dec 12, 2023
17 checks passed
@bouweandela bouweandela deleted the add-whatsnew-entries branch December 12, 2023 15:41
tkknight added a commit to tkknight/iris that referenced this pull request Dec 13, 2023
* upstream/main:
  ruff checks for numpydocs (SciTools#5630)
  Add whatsnew entries (SciTools#5626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants