Lazy rolling_window #5775
Merged
Lazy rolling_window #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
9 tasks
bouweandela
force-pushed
the
lazy-rolling-window
branch
2 times, most recently
from
0650a00
to
6f02c66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5775 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 92 92
Lines 22940 22941 +1
Branches 5462 5463 +1
=======================================
+ Hits 20588 20589 +1
Misses 1620 1620
Partials 732 732 ☔ View full report in Codecov by Sentry. |
bouweandela
force-pushed
the
lazy-rolling-window
branch
from
6f02c66
to
bb2ec46
Compare
trexfeathers
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Thanks @bouweandela, a nice bit of modernisation. I had never worked with rolling_window() before, but now that I have learned about it your change looks ideal; we're all better for having your expertise 😊
|
Thank you for reviewing and for your kind words @trexfeathers! |
stephenworsley
pushed a commit
to stephenworsley/iris
that referenced
this pull request
Mar 11, 2024
* Lazy rolling_window * Add test and whatsnew entry
pp-mo
pushed a commit
to pp-mo/iris
that referenced
this pull request
Mar 11, 2024
* Lazy rolling_window * Add test and whatsnew entry
pp-mo
pushed a commit
to pp-mo/iris
that referenced
this pull request
Mar 11, 2024
* Lazy rolling_window * Add test and whatsnew entry
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Mar 13, 2024
…th_numpydoc * upstream/main: Bump scitools/workflows from 2024.03.0 to 2024.03.1 Bump scitools/workflows from 2024.02.2 to 2024.03.0 Fix usage of map_blocks in AreaWeighted and elsewhere (SciTools#5767) Lazy rolling_window (SciTools#5775) whatsnew update for 3.8.0 (SciTools#5793) Bump scitools/workflows from 2024.02.1 to 2024.02.2 (SciTools#5792) DOCS: Add whatsnew for recent PRs (SciTools#5789)
HGWright
added a commit
to HGWright/iris
that referenced
this pull request
Mar 27, 2024
* 'geo-bridge' of github.com:HGWright/iris: (41 commits) Updated lock files. [pre-commit.ci] auto fixes from pre-commit.com hooks Advertise structured_um_loading performance regression. [pre-commit.ci] pre-commit autoupdate Updated environment lockfiles [pre-commit.ci] auto fixes from pre-commit.com hooks [pre-commit.ci] pre-commit autoupdate Make the bugfix panel OPEN. What's New patch. What's New patch. Bump scitools/workflows from 2024.03.1 to 2024.03.3 Bump scitools/workflows from 2024.03.0 to 2024.03.1 Bump scitools/workflows from 2024.02.2 to 2024.03.0 Fix usage of map_blocks in AreaWeighted and elsewhere (SciTools#5767) Lazy rolling_window (SciTools#5775) whatsnew update for 3.8.0 (SciTools#5793) Bump scitools/workflows from 2024.02.1 to 2024.02.2 (SciTools#5792) DOCS: Add whatsnew for recent PRs (SciTools#5789) ASV custom build command and file-based benchmark triggers (SciTools#5776) DOCS: Enable numpydoc validation pre-commit hook (SciTools#5762) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #5774
Consult Iris pull request check list