New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASV custom build command and file-based benchmark triggers #5776
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5776 +/- ##
=======================================
Coverage 89.74% 89.74%
=======================================
Files 92 92
Lines 22940 22940
Branches 5462 5462
=======================================
Hits 20588 20588
Misses 1620 1620
Partials 732 732 ☔ View full report in Codecov by Sentry. |
Performance Benchmark Report: 0822457Performance shifts
Full benchmark results
Generated by GHA run |
⏱️ Performance Benchmark Report: 1b43151Performance shifts
Full benchmark results
Generated by GHA run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trexfeathers, a few changes as we discussed. But this should make it a lot easier to keep track of and own performance regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes @trexfeathers!
* main: ASV custom build command and file-based benchmark triggers (SciTools#5776) DOCS: Enable numpydoc validation pre-commit hook (SciTools#5762) RUFF: fix legacy use of np.numpy.random (SciTools#5786)
Many thanks, @HGWright 🙂 |
…5776) * Trigger benchmarks if lock files have changed. * Check for 'true' string not boolean * Temporarily disable other CI. * Limit branch actions to pull requests * Unified continue check. * Benchmarks temporary debug mode. * Demonstrate lock file trigger for benchmarks. * Demonstrate overnight mode. * Revert "Demonstrate overnight mode." This reverts commit fbb4ab7. * Revert "Demonstrate lock file trigger for benchmarks." This reverts commit 5522251. * Minor visual improvements. * Explanatory notes. * Revert "Benchmarks temporary debug mode." This reverts commit 8f097b1. * Revert "Temporarily disable other CI." This reverts commit 621a774. * Fix docs indentation. * Custom ASV build command using setup.py. * Remove ASV pin. * Don't trigger benchmarks when pyproject.toml changes. * More accurate name for files-changed step. * Don't have a continue output. * Remove confusing variable name clash. * Update What's New entry.
…5776) * Trigger benchmarks if lock files have changed. * Check for 'true' string not boolean * Temporarily disable other CI. * Limit branch actions to pull requests * Unified continue check. * Benchmarks temporary debug mode. * Demonstrate lock file trigger for benchmarks. * Demonstrate overnight mode. * Revert "Demonstrate overnight mode." This reverts commit fbb4ab7. * Revert "Demonstrate lock file trigger for benchmarks." This reverts commit 5522251. * Minor visual improvements. * Explanatory notes. * Revert "Benchmarks temporary debug mode." This reverts commit 8f097b1. * Revert "Temporarily disable other CI." This reverts commit 621a774. * Fix docs indentation. * Custom ASV build command using setup.py. * Remove ASV pin. * Don't trigger benchmarks when pyproject.toml changes. * More accurate name for files-changed step. * Don't have a continue output. * Remove confusing variable name clash. * Update What's New entry.
…5776) * Trigger benchmarks if lock files have changed. * Check for 'true' string not boolean * Temporarily disable other CI. * Limit branch actions to pull requests * Unified continue check. * Benchmarks temporary debug mode. * Demonstrate lock file trigger for benchmarks. * Demonstrate overnight mode. * Revert "Demonstrate overnight mode." This reverts commit fbb4ab7. * Revert "Demonstrate lock file trigger for benchmarks." This reverts commit 5522251. * Minor visual improvements. * Explanatory notes. * Revert "Benchmarks temporary debug mode." This reverts commit 8f097b1. * Revert "Temporarily disable other CI." This reverts commit 621a774. * Fix docs indentation. * Custom ASV build command using setup.py. * Remove ASV pin. * Don't trigger benchmarks when pyproject.toml changes. * More accurate name for files-changed step. * Don't have a continue output. * Remove confusing variable name clash. * Update What's New entry.
* 'geo-bridge' of github.com:HGWright/iris: (41 commits) Updated lock files. [pre-commit.ci] auto fixes from pre-commit.com hooks Advertise structured_um_loading performance regression. [pre-commit.ci] pre-commit autoupdate Updated environment lockfiles [pre-commit.ci] auto fixes from pre-commit.com hooks [pre-commit.ci] pre-commit autoupdate Make the bugfix panel OPEN. What's New patch. What's New patch. Bump scitools/workflows from 2024.03.1 to 2024.03.3 Bump scitools/workflows from 2024.03.0 to 2024.03.1 Bump scitools/workflows from 2024.02.2 to 2024.03.0 Fix usage of map_blocks in AreaWeighted and elsewhere (SciTools#5767) Lazy rolling_window (SciTools#5775) whatsnew update for 3.8.0 (SciTools#5793) Bump scitools/workflows from 2024.02.1 to 2024.02.2 (SciTools#5792) DOCS: Add whatsnew for recent PRs (SciTools#5789) ASV custom build command and file-based benchmark triggers (SciTools#5776) DOCS: Enable numpydoc validation pre-commit hook (SciTools#5762) ...
🚀 Pull Request
Description
build_command
inasv.conf.json
to use Iris'setup.py
fileConsult Iris pull request check list