Convert unit/fileformats/cf to pytest #5873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_pytest_conversion #5873 +/- ##
=============================================================
- Coverage 89.75% 89.69% -0.07%
=============================================================
Files 92 92
Lines 22940 22940
Branches 5462 5462
=============================================================
- Hits 20590 20575 -15
- Misses 1619 1638 +19
+ Partials 731 727 -4 ☔ View full report in Codecov by Sentry. |
bjlittle
requested changes
Mar 20, 2024
| # TODO: unit tests for existing functionality pre 2021-03-11. | ||
| def setUp(self): | ||
| def setup_method(self): |
| @@ -41,4 +36,4 @@ def test_non_data_names(self): | |||
|
|
|||
| expected_names = [var.cf_name for var in (aux_var, coord_var, coord_var2)] | |||
| expected = set(expected_names) | |||
| self.assertEqual(expected, self.cf_group.non_data_variable_names) | |||
| assert expected == self.cf_group.non_data_variable_names | |||
There was a problem hiding this comment.
@pp-mo Swap order here i.e., actual == expected
bjlittle
approved these changes
Mar 22, 2024
bjlittle
merged commit 6b9b53a
into
SciTools:FEATURE_pytest_conversion
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.