-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert unit/fileformats/cf to pytest #5873
Merged
bjlittle
merged 2 commits into
SciTools:FEATURE_pytest_conversion
from
pp-mo:pytests_unit_fileformats_cf
Mar 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,6 @@ | |
# This file is part of Iris and is released under the BSD license. | ||
# See LICENSE in the root of the repository for full licensing details. | ||
"""Unit tests for the :class:`iris.fileformats.cf.CFGroup` class.""" | ||
|
||
from unittest.mock import MagicMock | ||
|
||
from iris.fileformats.cf import ( | ||
|
@@ -13,14 +12,10 @@ | |
CFGroup, | ||
) | ||
|
||
# Import iris.tests first so that some things can be initialised before | ||
# importing anything else. | ||
import iris.tests as tests | ||
|
||
|
||
class Tests(tests.IrisTest): | ||
class Tests: | ||
# TODO: unit tests for existing functionality pre 2021-03-11. | ||
def setUp(self): | ||
def setup_method(self): | ||
self.cf_group = CFGroup() | ||
|
||
def test_non_data_names(self): | ||
|
@@ -41,4 +36,4 @@ def test_non_data_names(self): | |
|
||
expected_names = [var.cf_name for var in (aux_var, coord_var, coord_var2)] | ||
expected = set(expected_names) | ||
self.assertEqual(expected, self.cf_group.non_data_variable_names) | ||
assert expected == self.cf_group.non_data_variable_names | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @pp-mo Swap order here i.e., |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pp-mo Adopt fixture pattern?