Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh infra-structure and support cython 3.x #16

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Oct 19, 2023

This pull-request gives some well overdue ❤️ to mo_pack, breathing life back into repo and allowing it to build and test against py312.

In a nutshell, the changes include:

  • Uses a modern .gitignore for python, see here
  • Adopting auto-versioning with setuptools-scm
  • Adopts assorted developer and best practice pre-commit hooks
  • Configures pytest for testing
  • Refreshes the README.md
  • Adopts PEP 621 for storing project metadata in the pyproject.toml
  • Adopts PEP 517 and PEP 518
  • Adopts NEP 029 and the Drop Schedule
  • Captures the package conda requirements in requirements/mo_pack.yml
  • Refreshes the setup.py to work with cython 3.x
  • Introduces an minimum pin of cython>=3
  • Purges legacy python 2.x future imports
  • For continuous-integration:
    • Enables the pre-commit.ci service for the repo
    • Adopts use of dependabot
    • Checks the manifest of the sdist
    • Builds and tests mo_pack with py39, py310, py311 and py312

@bjlittle
Copy link
Member Author

As this PR initiates bootstrapping the GHA CI, see https://github.com/bjlittle/mo_pack/actions for the successful CI job runs associated with the PR branch.

@bjlittle
Copy link
Member Author

FYI @jfrost-mo

@bjlittle
Copy link
Member Author

bjlittle commented Oct 19, 2023

Once this PR lands, I'll cut a release and then update the conda-forge feedstock with a new PR.

I'm currently not a maintainer of this package on the feedstock, but was going to add my name to the list and ping @ocefpaf for a merge.

@trexfeathers did you want me to also add you as a feedstock maintainer to cover the bases?

@trexfeathers
Copy link
Contributor

@trexfeathers did you want me to also add you as a feedstock maintainer to cover the bases?

I guess so 🙈

@bjlittle bjlittle removed the request for review from trexfeathers October 19, 2023 13:02
.gitignore Outdated Show resolved Hide resolved
@trexfeathers
Copy link
Contributor

@HGWright and @trexfeathers are sharing review duties.

Copy link

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor changes to consider. Thanks for the CI refresh!

.github/workflows/ci-manifest.yml Outdated Show resolved Hide resolved
.github/workflows/ci-tests.yml Outdated Show resolved Hide resolved
@bjlittle
Copy link
Member Author

@HGWright See https://github.com/bjlittle/mo_pack/actions for the GHA runs on the PR branch

Copy link

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjlittle
Copy link
Member Author

@trexfeathers I think we're good to roll with this now ...

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the poke.

I am also happy with the pieces I reviewed.

@trexfeathers trexfeathers merged commit cfaf341 into SciTools:main Oct 20, 2023
1 check passed
@bjlittle
Copy link
Member Author

Sweet!

Thanks guys. I'll cut a release later this afternoon and push a change to the feedstock afterwards 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants