-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh infra-structure and support cython 3.x #16
Conversation
As this PR initiates bootstrapping the GHA CI, see https://github.com/bjlittle/mo_pack/actions for the successful CI job runs associated with the PR branch. |
FYI @jfrost-mo |
Once this PR lands, I'll cut a release and then update the I'm currently not a maintainer of this package on the feedstock, but was going to add my name to the list and ping @ocefpaf for a merge. @trexfeathers did you want me to also add you as a feedstock maintainer to cover the bases? |
I guess so 🙈 |
@HGWright and @trexfeathers are sharing review duties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor changes to consider. Thanks for the CI refresh!
@HGWright See https://github.com/bjlittle/mo_pack/actions for the GHA runs on the PR branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@trexfeathers I think we're good to roll with this now ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the poke.
I am also happy with the pieces I reviewed.
Sweet! Thanks guys. I'll cut a release later this afternoon and push a change to the feedstock afterwards 🥳 |
This pull-request gives some well overdue ❤️ to
mo_pack
, breathing life back into repo and allowing it to build and test againstpy312
.In a nutshell, the changes include:
.gitignore
forpython
, see heresetuptools-scm
pre-commit
hookspytest
for testingREADME.md
pyproject.toml
conda
requirements inrequirements/mo_pack.yml
setup.py
to work withcython
3.xcython>=3
python
2.x futureimports
pre-commit.ci
service for the repodependabot
mo_pack
withpy39
,py310
,py311
andpy312