Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package dependency refactor #61

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Jun 1, 2020

This PR reorganises the conda dependencies for developers.

This is a simplification but also separates concerns between conda and pip.

All pip dependencies are maintained within the setup.cfg. If people want to use pip, then it'll work just fine.

However, as developers I believe that we should be opinionated, and that said, the recommendation is to use conda over pip, or if needed, pip within conda.

The pattern of maintaining the conda dependencies are now all under ci/requirements/py3. These are explicit dependencies per python version. This now allows us the freedom to have varying dependencies per python version, if needed - but in general my expectation is that this typically will be an exception.

The .travis.yml is now pretty simplified, as all the dependency magic is explicitly baked into the pyXX.yml configuration files. I'm keen that if this pattern is accepted that as a rule we can adopt the same approach to other SciTools repos - in particular iris which is a bit of a dogs breakfast when it comes to dependency management, particularly for users and developers alike.

@trexfeathers

@bjlittle bjlittle merged commit 8c60e89 into SciTools:master Jun 1, 2020
@bjlittle bjlittle deleted the optional-scooby-import branch June 2, 2020 08:40
@trexfeathers
Copy link
Contributor

I get the principle here @bjlittle, but it's a pretty big violation of D.R.Y.. Is there anything that can be put in place to help developers remember some changes will need to be repeated across files?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants