Skip to content

Commit

Permalink
Translation file for threes was lacking the as_labelled argument => c…
Browse files Browse the repository at this point in the history
…orrected
  • Loading branch information
phgrosjean committed Oct 27, 2018
1 parent 2456cb9 commit b9a69c1
Show file tree
Hide file tree
Showing 14 changed files with 25 additions and 38 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: data.io
Type: Package
Version: 1.2.0
Version: 1.2.1
Title: Data Input/Output, Read or Write Data from Files or Datasets in R Packages in Different Formats
Description: Read or write data from many different formats (tabular datasets,
from statistic software, ...) into R objects. Add labels and units in
Expand All @@ -17,5 +17,5 @@ LazyData: true
URL: https://github.com/SciViews/data.io, http://www.sciviews.org/SciViews-R
BugReports: https://github.com/SciViews/data.io/issues
Roxygen: list(markdown = TRUE)
RoxygenNote: 6.0.1
RoxygenNote: 6.1.0
VignetteBuilder: knitr
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# data.io News

## Changes in data.io 1.2.1

- the French translation for the trees dataset had no as_labelled argument


## Changes in data.io 1.2.0

- It is now possible to specify the default language to use for read() with
Expand Down
2 changes: 1 addition & 1 deletion R/data.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
#' and its content.}
#' \item{\code{gonads}}{Weight (in g) of the gonads.}
#' \item{\code{dry_gonads}}{Dry weight (in g) of the gonads.}
#' \item{\code{skeleton}}{Weight of the skeleton (g), calculated as the sum of
#' \item{\code{skeleton}}{Weight of the skeleton (g), calculated as the sum of
#' lantern + test + spines.}
#' \item{\code{lantern}}{Dry weight (in g) of the lantern (the jaw and teeths of
#' the sea urchin).}
Expand Down
2 changes: 0 additions & 2 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

* Completion in R and RStudio for `read$` and `write$`.

* geyser translation files are missing!

* label versus comment for a dataframe?

* Rework the read() function.
Expand Down
6 changes: 3 additions & 3 deletions inst/translation/trees_fr.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.trees_en <- function(trees, labels_only = FALSE) {
.trees_en <- function(trees, labels_only = FALSE, as_labelled = FALSE) {
# The trees dataset has a couple of glitches:
# 1) Girth is indeed the Diameter (and variables not in snake_case), so rename
names(trees) <- c("diameter", "height", "volume")
Expand All @@ -22,8 +22,8 @@
units = list(
diameter = "m",
height = "m",
volume = "m^3")
)
volume = "m^3"),
as_labelled = as_labelled)

#if (!isTRUE(labels_only)) {
# Nothing to do!
Expand Down
4 changes: 1 addition & 3 deletions man/as_dataframe.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions man/data_example.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions man/data_types.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 5 additions & 6 deletions man/labelise.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions man/read.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions man/read_write_option.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion man/reexports.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions man/relative_path.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions man/write.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b9a69c1

Please sign in to comment.