Merge pull request #1539 from Scille/gui-fix-crash-macos

[GUI] Fixed crash on MacOS when resetting a greyed dialog parent

newsfragments/1538.bugfix.rst

@@ -0,0 +1 @@
+Fixed crash on MacOS when closing a dialog

parsec/core/gui/custom_dialogs.py

@@ -105,7 +105,11 @@ def on_finished(self):
         ):
             getattr(self.center_widget, "on_close")()
         self.closing.emit()
-        self.setParent(None)
+        # On Windows, GreyedDialogs don't get cleared out if their parent
+        # is not set to None. Linux seems to clear them automatically over time.
+        # Resetting the parent on MacOS causes a crash.
+        if platform.system() != "Darwin":
+            self.setParent(None)
 
 
 class TextInputWidget(QWidget, Ui_InputWidget):
@@ -264,7 +268,7 @@ def toggle_details(self, checked):
 def show_error(parent, message, exception=None):
     w = ErrorWidget(message, exception)
     d = GreyedDialog(w, title=_("TEXT_ERR_DIALOG_TITLE"), parent=parent)
-    return d.exec_()
+    return d.open()
 
 
 class InfoWidget(QWidget, Ui_InfoWidget):
@@ -292,4 +296,4 @@ def show_info(parent, message, button_text=None):
     d = GreyedDialog(w, title=None, parent=parent, hide_close=True)
     w.dialog = d
     w.button_ok.setFocus()
-    return d.exec_()
+    return d.open()

tests/core/gui/conftest.py

@@ -232,6 +232,9 @@ def _dialog_exec(dialog):
     monkeypatch.setattr(
         "parsec.core.gui.custom_dialogs.GreyedDialog.exec_", _dialog_exec, raising=False
     )
+    monkeypatch.setattr(
+        "parsec.core.gui.custom_dialogs.GreyedDialog.open", _dialog_exec, raising=False
+    )
     return spy