Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Fixed crash on MacOS when resetting a greyed dialog parent #1539

Merged
merged 1 commit into from Nov 3, 2020

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Oct 27, 2020

Closes #1538

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1539 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
+ Coverage   87.71%   87.82%   +0.10%     
==========================================
  Files         241      241              
  Lines       22952    22953       +1     
==========================================
+ Hits        20132    20158      +26     
+ Misses       2820     2795      -25     
Impacted Files Coverage Δ
parsec/core/gui/custom_dialogs.py 80.40% <100.00%> (+0.09%) ⬆️
parsec/core/gui/parsec_application.py 93.47% <0.00%> (-2.18%) ⬇️
parsec/core/fs/remote_loader.py 84.73% <0.00%> (-0.77%) ⬇️
parsec/backend/postgresql/invite.py 95.73% <0.00%> (-0.61%) ⬇️
parsec/core/fs/workspacefs/workspacefs.py 97.32% <0.00%> (-0.30%) ⬇️
parsec/core/gui/workspaces_widget.py 83.22% <0.00%> (+0.21%) ⬆️
parsec/core/fs/userfs/userfs.py 85.96% <0.00%> (+0.43%) ⬆️
parsec/core/gui/greet_user_widget.py 86.62% <0.00%> (+0.58%) ⬆️
parsec/backend/app.py 93.54% <0.00%> (+1.07%) ⬆️
parsec/core/sync_monitor.py 93.22% <0.00%> (+1.19%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96877d6...fb6bdd3. Read the comment docs.

Copy link
Contributor

@Ironicbay Ironicbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Max-7 Max-7 merged commit b6aad68 into master Nov 3, 2020
@Max-7 Max-7 deleted the gui-fix-crash-macos branch November 3, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on MacOS when resetting the parent of a greyed dialog
2 participants