-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ListField as marshmallow field params #102
Conversation
tests/test_marshmallow.py
Outdated
{'brief': 'lighter', 'value': 2, 'name': 'Unknown'}] | ||
} | ||
ret = ma_schema.load(data) | ||
assert ret.errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert ret.errors
seems too vague, could it be possible to test the error dict itself ?
assert ret.errors = {'_schema': ['tough shit...']}
# Or at least test the field causing the error
assert '_schema' in ret.errors
So basically #101 saved the day and this PR just add unittest ? 😄 |
Not exactly. Look at the last commit. I also modified (And I also fixed a potential issue in I'll rework the test as suggested in your review once we're done with #101. |
Rebased and pushed into another PR: #150. |
Fixes #64.
This PR is based on #101.