Fix ListField as marshmallow field params #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleMan
reviewed
Mar 28, 2017
tests/test_marshmallow.py
Outdated
| {'brief': 'lighter', 'value': 2, 'name': 'Unknown'}] | ||
| } | ||
| ret = ma_schema.load(data) | ||
| assert ret.errors |
There was a problem hiding this comment.
assert ret.errors seems too vague, could it be possible to test the error dict itself ?
assert ret.errors = {'_schema': ['tough shit...']}
# Or at least test the field causing the error
assert '_schema' in ret.errors
|
So basically #101 saved the day and this PR just add unittest ? 😄 |
|
Not exactly. Look at the last commit. I also modified (And I also fixed a potential issue in I'll rework the test as suggested in your review once we're done with #101. |
|
Rebased and pushed into another PR: #150. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64.
This PR is based on #101.