Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pymongo a mandatory dependency (it is needed for bson) #148

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Make pymongo a mandatory dependency (it is needed for bson) #148

merged 1 commit into from
Nov 28, 2018

Conversation

lafrech
Copy link
Collaborator

@lafrech lafrech commented Nov 28, 2018

pymongo should be a hard dependency because bson is imported in the main code.

Also, there is no need to test the version is > 3.2 if 3.2 is required.

@coveralls
Copy link

coveralls commented Nov 28, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 95.696% when pulling e7b0aa7 on make_pymongo_mandatory into db076f6 on master.

@lafrech lafrech mentioned this pull request Nov 28, 2018
Merged
touilleMan
touilleMan approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lafrech lafrech merged commit 9bc2f02 into master Nov 28, 2018
@lafrech lafrech deleted the make_pymongo_mandatory branch November 28, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@touilleMan touilleMan touilleMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lafrech @coveralls @touilleMan