Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://api.mongodb.com/python/current/changelog.html
This PR is based on #148.
It adds a
count
method toPyMongoDocument
. (I named itcount
and notcount_documents
to match umongo'sTxMongoDocument
. I have no objection to naming itcount_documents
.)I'd do the same for
MotorAsyncIODocument
except it requires motor>=2.0, which is not supported.Since we already require pymongo 3.x, I figured bumping the requirement wouldn't be too much of an issue and would save us the pain of supporting both 3.7 and 3.6-. I could rework to only add the new
count
method if using 3.7 and only require 3.7 in the tests. But I'm not sure it is worth the trouble.