New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove as_attribute argument of register method #290

Merged

lafrech merged 1 commit into master from remove_as_attribute

Jul 20, 2020

Collaborator

lafrech commented Jul 20, 2020

This feature is broken.

If as_attribute is False, the check performed to raise AlreadyRegisteredDocumentError is screwed.
There could be name clashes between different doc types (document, embedded, mixin).

Removing it solves the name clash issue. It means the user can not access a document as instance.MyDocument anymore but it is not that bad.


          Remove as_attribute argument of register method

d3ec99f

lafrech added this to the 3.0 milestone

lafrech merged commit 5636cc4 into master

lafrech deleted the remove_as_attribute branch

July 20, 2020 15:35

coveralls commented Jul 20, 2020

Coverage decreased (-10.0%) to 85.498% when pulling d3ec99f on remove_as_attribute into 5aed75f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet