Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should fix #25 #28

Closed
wants to merge 4 commits into from
Closed

Should fix #25 #28

wants to merge 4 commits into from

Conversation

vsl7
Copy link
Contributor

@vsl7 vsl7 commented Sep 5, 2021

No description provided.

@nyamatongwe
Copy link
Member

It appears that @-moz-document has been removed from FireFox and @document hasn't been included in the W3C Conditional Rules Module. Should these really be included?

@vsl7
Copy link
Contributor Author

vsl7 commented Sep 7, 2021

@nyamatongwe Yes, because they may be used in style sheets. Not supporting them breaks parsing, highlighting and pair bracket detection. @-moz-document has not been removed from Firefox, it is supported in user style sheets.

nyamatongwe pushed a commit that referenced this pull request Sep 11, 2021
@vsl7 @nyamatongwe
#25 Implement conditional group rules in CSS.
c2d1cce 
Based on pull request #28.
@nyamatongwe
Copy link
Member

There were some problems with this pull request (SciLexer.h was changed then changed back so LexCSS.cxx didn't compile) so the changes were committed as c2d1cce.

LexicalStyles.iface is the source of style definitions so it should be updated first then scripts/LexillaGen.py run to produce SciLexer.h.

Change sets should also include an example in test/examples/{lexer} as has been added in test/examples/css/AllStyles.css. The output .styled and .folded files are created and used as described in test/README.

The change is credited to vsl7. If you want a different name in the credits then please specify your preference.

@zufuliu zufuliu mentioned this pull request Sep 12, 2021
Closed
@nyamatongwe nyamatongwe added the css Caused by the css lexer label Sep 15, 2021
@elextr elextr mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css Caused by the css lexer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vsl7 @nyamatongwe