kscript: Add version 4.1.1 #9353
Conversation
|
/verify |
|
All changes look good. Wait for review from human collaborators. kscript
|
|
There should be a dependency on kotlin, as the installation guide says |
|
/verify |
|
All changes look good. Wait for review from human collaborators. kscript
|
|
shouldn't it be |
|
Maybe the user already has a kotlin compiler in their PATH and doesn't want another one. It would still be fine for me to put it as a dependency, but maybe some people might not like having kotlin installed as well. I also noticed that many jsons only suggest installing the visual c redistributables and don't enforce it as a dependency. |
|
It is an interesting question: how should it work in scoop? Looking and macOS brew, it force installs the dependencies. But brew is de facto standard macOS tool. We have so many alternative package managers on windows... It might be reasonable not to install the dependencies. Maybe we need maintainers to shed some light on the desired behavior? |
|
I looked up the documentation, and it says:
So that means kotlin should be in |
|
I replaced suggest with depends and added a note informing the user of installing kotlin. |
|
/verify |
|
All changes look good. Wait for review from human collaborators. kscript
|
|
/verify |
|
Your changes do not pass checks. kscript
|
|
@Dany-coder778, there is an error in the pipelines because of the file formatting. |
Co-authored-by: Andrew Yefanov <1134togo@gmail.com>
|
/verify |
|
Your changes do not pass checks. kscript
|
Added kscript.json to the bucket