Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wkhtmltopdf : Add version 0.12.5-1 #4507

Closed

Conversation

Baneeishaque
Copy link
Contributor

@Baneeishaque Baneeishaque commented Mar 4, 2023

wkhtmltopdf and wkhtmltoimage are open source (LGPLv3) command line tools to render HTML into PDF and various image formats using the Qt WebKit rendering engine. These run entirely "headless" and do not require a display or display service.

There is already an App Manifest for wkhtmltopdf, See here. But, it use the wkhtmltopdf/packaging repository which only contains releases for 0.12.6. The older releases are in wkhtmltopdf/wkhtmltopdf repository & currently it is in archived state.

The requirement of wkhtmltopdf 0.12.5 is that : Odoo 16 needs 0.12.5 version of wkhtmltopdf as dependency in windows, See https://www.odoo.com/documentation/16.0/administration/install/install.html#setup-install-source.

Odoo is a suite of business management software tools including, for example, CRM, e-commerce, billing, accounting, manufacturing, warehouse, project management, and inventory management.

@Baneeishaque
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2023

All changes look good.

Wait for review from human collaborators.

wkhtmltopdf.0.12.5-1

  • Description
  • License
  • Hashes

@rashil2000
Copy link
Member

Versioned manifests go in the Versions bucket. Please move this PR there.

Also, do Odoo devs recommend against using versions later than 0.12.5-1? All I can see on https://github.com/odoo/odoo/wiki/Wkhtmltopdf is that they have mentioned uptil 0.12.5-1, and I assume 0.12.6-1 should be compatible too.

@rashil2000 rashil2000 closed this Mar 5, 2023
@Baneeishaque
Copy link
Contributor Author

Baneeishaque commented Mar 5, 2023

Also, do Odoo devs recommend against using versions later than 0.12.5-1? All I can see on https://github.com/odoo/odoo/wiki/Wkhtmltopdf is that they have mentioned uptil 0.12.5-1, and I assume 0.12.6-1 should be compatible too.

0.12.6-1 is not tested yet.

@Baneeishaque
Copy link
Contributor Author

Versioned manifests go in the Versions bucket. Please move this PR there.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants