Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about recent OpenSSH issues #2414

Closed
r15ch13 opened this issue Jul 20, 2018 · 6 comments
Closed

Discussion about recent OpenSSH issues #2414

r15ch13 opened this issue Jul 20, 2018 · 6 comments
Assignees

Comments

@r15ch13
Copy link
Member

r15ch13 commented Jul 20, 2018

Wanted to discuss the issues OpenSSH is causing lately.

Possible solutions:

  1. leave the manifest like it is now? openssh.json
  2. use another download source than repo.msys2.org
  3. swap it with the git-with-openssh manifest silently
    a. version property shows GIT version instead of OpenSSH
    b. auto update works
  4. change it to an fixed version of git-with-openssh (Example: rivy/openssh)
    a. version property shows OpenSSH version
    b. no auto update
  5. change it to win32-openssh silently
    a. it's still in beta
  6. change it to a meta package that installs git-with-openssh via depends property?
  7. change it to an empty meta package that does nothing
    a. will most likely kill all automated processes
    {
        "homepage": "https://git-for-windows.github.io/",
        "url": "https://git-for-windows.github.io/",
        "license": "GPL-2.0",
        "version": "7.7p1",
        "suggest": {
            "Git with OpenSSH": [
                "git-with-openssh"
            ],
            "Portable OpenSSH": [
                "win32-openssh"
            ]
        },
        "notes": "This is a placeholder! Please install 'git-with-openssh' or 'win32-openssh' instead!"
    }
@rasa
Copy link
Member

rasa commented Jul 20, 2018

I implemented item 6. above in a proof-of-concept in #2431 . Both install and uninstall work, but we should really kick the tires before merging it in.

@gbursson
Copy link
Contributor

If I can add my 0.02PLN:
change it to win32-openssh silently

The fact that it's still in beta should not matter, I believe it's mature enough to be used.

@chawyehsu
Copy link
Member

chawyehsu commented Jul 25, 2018

Changing openssh to win32-openssh is my suggestion. It does not matter that it's still in beta, because Windows 10 RS4 has included it as a built-in tool. This is a good enough reason.

@rasa
Copy link
Member

rasa commented Jul 25, 2018

I added an rsync-via-git.json to #2431 to show how we can easily install other apps inside the git app's directory. Initial testing is encouraging.

@se35710
Copy link
Contributor

se35710 commented Aug 4, 2018

There is also the PuTTY way, using plink and Pageant:

  1. $Env:GIT_SSH=~\scoop\apps\putty\current\plink.exe
  2. Import the key to PuTTY's Pageant
  3. Clone repo and set remote.origin.url=git@github.com:<username>/<repo>.git

@chawyehsu
Copy link
Member

But another problem is, win32-openssh isn't a good choice for those users who don't have elevated permission, since it is implemented as an OS service, restricted users cannot install its services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants