Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mls-software-openssh #2632

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Add mls-software-openssh #2632

merged 2 commits into from
Oct 23, 2018

Conversation

chawyehsu
Copy link
Member

@chawyehsu chawyehsu commented Sep 30, 2018

Another choice of openssh. #2414

chocolatey package

@Ash258
Copy link
Contributor

Ash258 commented Oct 18, 2018

I would suggest to split parameters into separate strings and rename it to something like openssh-mls

@chawyehsu
Copy link
Member Author

@Ash258

  1. I have tested that. If args are split, the installation would be broken, you could try it by making a copy locally.
  2. The manifest name is the same as the choco's one, which I prefer to keep uniform app name. But if you like.

@Ash258
Copy link
Contributor

Ash258 commented Oct 18, 2018

Work as expected. Did you followed this page?

proof

@Ash258
Copy link
Contributor

Ash258 commented Oct 18, 2018

For that naming. It would be best to keep all these openssh variations together.

@Ash258
Copy link
Contributor

Ash258 commented Oct 18, 2018

Also installer for 32bit could be useful.

/x86=# specify set to 1 to force x86 install on x64.

Based on this it's used by default when on 32bit machine, but someone want to install 32bit while using 64bit machine.

@chawyehsu
Copy link
Member Author

I can't reproduce now, the last time I installed without using admin rights, but now it requires admin rights. Besides, there is no naming standard, so there is no best choice. As an user, I will search apps by typing scoop search openssh, so openssh-mls has no difference with mls-software-openssh for me. But if all openssh variations need to be kept together, it's ok to rename it. Like from win32-openssh to openssh-win32...

@Ash258
Copy link
Contributor

Ash258 commented Oct 18, 2018

Tested with separate arguments and unelevated prompt (now with pwsh instead of powershell). Work as expected, but UAC popped (for installing and uninstalling).
Unelevated

@chawyehsu
Copy link
Member Author

Just changed to extract mode, now say goodbye to UAC, everything works like a charm.

@r15ch13 r15ch13 merged commit 8058a75 into ScoopInstaller:master Oct 23, 2018
@chawyehsu chawyehsu deleted the patch-2 branch October 23, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants