Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zstd for extraction #3990

Closed
trajano opened this issue May 19, 2020 · 16 comments
Closed

Support zstd for extraction #3990

trajano opened this issue May 19, 2020 · 16 comments

Comments

@trajano
Copy link

trajano commented May 19, 2020

Msys2 repo uses zstd for their new packages, can you add support for zstd decompression?

@Calinou
Copy link
Contributor

Calinou commented May 19, 2020

Scoop depends on 7-zip to extract formats other than ZIP, but the official 7-zip distribution doesn't support Zstandard. Many third-party forks do, though.

@r15ch13
Copy link
Member

r15ch13 commented May 19, 2020

Scoop can use 7zip-zstd.

scoop bucket add versions
scoop install 7zip-zstd
scoop uninstall 7zip

https://github.com/lukesampson/scoop/blob/96de9c14bb483f9278e4b0a9e22b1923ee752901/lib/core.ps1#L252-L258

@Augiiz
Copy link

Augiiz commented May 19, 2020

Still no luck extracting zst packages upon installation, they just sit there.

@r15ch13
Copy link
Member

r15ch13 commented May 19, 2020

Do you have some example files?

@Augiiz
Copy link

Augiiz commented May 19, 2020

Since main buckets gcc still on 9.3 trying to set up my own bucket for gcc 10, but mingw moved some of their archives to zst starting gcc 10.

My bucket: https://github.com/Augiiz/scoop-gcc/blob/master/gcc-a.json

@niheaven
Copy link
Member

Need some manual tweaks:

  1. Add zst to L19 of lib/decompress.ps1 of scoop (%SCOOP%/apps/scoop/current/lib/decompress.ps1)
  2. scoop reset 7zip-zstd
  3. Install your gcc10

@Augiiz
Copy link

Augiiz commented May 20, 2020

Did it for me, thanks a bunch.

@trajano
Copy link
Author

trajano commented May 20, 2020

Scoop depends on 7-zip to extract formats other than ZIP, but the official 7-zip distribution doesn't support Zstandard. Many third-party forks do, though.

Is there a PR on the 7Zip mainline to integrate it?

@Calinou
Copy link
Contributor

Calinou commented May 20, 2020

@trajano I think there have been several, but none of them was merged so far: https://sourceforge.net/p/sevenzip/discussion/45797/thread/a7e4f3f3/

@trajano
Copy link
Author

trajano commented May 20, 2020

@Calinou from the discussions you linked it seems that there's no further work on integrating it and it had started in 2016. Maybe scoop should consider an alternative to 7z or at least use the official distribution to do the decompression at least it would decouple scoop from 7zip in case there are new compression formats that it does not support.

@wstein
Copy link

wstein commented Oct 11, 2020

msys2 has purged many older file version.
Now many packages of msys2 are only available as zstd compressed files.

If this issue will not be fixed, the msys2 based packages like gcc and openssh should be dropped.

@psydvl
Copy link

psydvl commented Jun 15, 2021

There are also zstd package in main bucket
Why not use only it?
https://github.com/ScoopInstaller/Main/blob/master/bucket/zstd.json

@silverkorn

This comment has been minimized.

@silverkorn

This comment has been minimized.

@ScoopInstaller ScoopInstaller deleted a comment from Ash258 Nov 1, 2021
@rashil2000
Copy link
Member

This is a pretty important blocker right now.

@niheaven Since you are somewhat familiar with Scoop's internals, can you have a look at which one of these is more appropriate - #4137 or #4372?

@rasa
Copy link
Member

rasa commented Nov 1, 2021

Imo, #4372 is probably more appropriate, as it appears to borrow heavily from https://github.com/Ash258/Scoop-Core/pull/97/files .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants