fix(core): Handle scoop aliases and broken(edited,copied) shim #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, update changelog? |
|
Done. |
rashil2000
reviewed
Oct 3, 2023
|
Also there are conflicts. |
Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
CrendKing
pushed a commit
to CrendKing/Scoop
that referenced
this pull request
Oct 3, 2023
…pInstaller#5551) * fix(core): Avoid error messages when shim broked, Allow get path for scoop aliases * update `scoop-which` * Add CHANGELOG entry * Update CHANGELOG.md Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com> --------- Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
scoop-whichcannot get path when these case:scoop which <manually creaetd/edited shim missing shimTarget>scoop which <copied shim>e.g. moving Scoop root directory from other locationsscoop which scoop-<scoop_alias>How Has This Been Tested?
Checklist:
developbranch.