Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Cleanup some old codes, e.g., msi section and config migration #5715

Merged
merged 6 commits into from Mar 6, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Nov 6, 2023

Description

Nothing special, just codes cleanup.

Motivation and Context

Config file migration codes should be removed after 2023/06/30 (nearly 1yr for the codes), and msi section is deprecated about 7yrs ago.

How Has This Been Tested?

All tests passed, and no new test added.

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

rashil2000
rashil2000 previously approved these changes Jan 4, 2024
@niheaven niheaven merged commit 7e3dc73 into develop Mar 6, 2024
2 checks passed
@niheaven niheaven deleted the cleanup-code branch March 6, 2024 13:04
niheaven added a commit that referenced this pull request Mar 7, 2024
@niheaven niheaven mentioned this pull request Mar 7, 2024
5 tasks
niheaven added a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants