-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filtering function for buckets page. #54
Conversation
Thanks for this PR! |
Thank you for watching. |
@@ -148,6 +151,18 @@ const Buckets = (): JSX.Element => { | |||
</Form.Select> | |||
</InputGroup> | |||
</Col> | |||
<Col lg={3}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to have a similar search field design between apps and buckets
return ret; | ||
} | ||
|
||
const filterIncludesKeywordBuckets = (item: Bucket) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we update the search query and rely on search results instead of filtering locally the buckets?
The goal is to have a consistent experience between apps and buckets (updated buckets counter for example) and to easily extend the buckets page later (filtering by official/popular buckets...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I understand🙂
Next, I will try to optimize the long list through virtual lists...