Add filtering function for buckets page. #54

playMudKing · 2023-04-17T02:08:32Z

Added filtering module for bucket.
Independent BucketList for Rendering performance.
Keyword Highlighting.

Next, I will try to optimize the long list through virtual lists...

gpailler · 2023-04-18T02:00:06Z

Thanks for this PR!
It's a great addition to add filtering / paging on buckets page and I will try to take a look on the PR later today
👍

playMudKing · 2023-04-18T02:17:15Z

Thanks for this PR! It's a great addition to add filtering / paging on buckets page and I will try to take a look on the PR later today 👍

Thank you for watching.
Scoop is my favorite installation tool for windows, So I am honored to be able toParticipate in it.🙂

gpailler · 2023-04-19T02:20:51Z

src/components/Buckets.tsx

@@ -148,6 +151,18 @@ const Buckets = (): JSX.Element => {
              </Form.Select>
            </InputGroup>
          </Col>
+          <Col lg={3}>


It would be better to have a similar search field design between apps and buckets

gpailler · 2023-04-19T02:25:41Z

src/components/BucketsList.tsx

+        return ret;
+    }
+
+    const filterIncludesKeywordBuckets = (item: Bucket) => {


Could we update the search query and rely on search results instead of filtering locally the buckets?
The goal is to have a consistent experience between apps and buckets (updated buckets counter for example) and to easily extend the buckets page later (filtering by official/popular buckets...)

Okay, I understand🙂

playMudKing added 2 commits April 17, 2023 09:05

feat(buckets-page): Add Buckets filtering module.

9e5d515

fix(buckets): Cover mark-el style

e48dbd5

gpailler reviewed Apr 19, 2023

View reviewed changes

playMudKing closed this Apr 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add filtering function for buckets page. #54

Add filtering function for buckets page. #54

playMudKing commented Apr 17, 2023

gpailler commented Apr 18, 2023

playMudKing commented Apr 18, 2023

gpailler Apr 19, 2023

gpailler Apr 19, 2023

playMudKing Apr 19, 2023

Add filtering function for buckets page. #54

Add filtering function for buckets page. #54

Conversation

playMudKing commented Apr 17, 2023

gpailler commented Apr 18, 2023

playMudKing commented Apr 18, 2023

gpailler Apr 19, 2023

Choose a reason for hiding this comment

gpailler Apr 19, 2023

Choose a reason for hiding this comment

playMudKing Apr 19, 2023

Choose a reason for hiding this comment