Feat add uber fx #331
Merged
Feat add uber fx #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 14.19% 14.20% +0.01%
==========================================
Files 31 31
Lines 2558 2556 -2
==========================================
Hits 363 363
+ Misses 2166 2164 -2
Partials 29 29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ssion to bind to 0.0.0.0
|
Tested locally, works good. Found a few bugs in UI. |
Are the UI bugs documented? Anyway, looks very good to me, very good job with breaking down of master.go, and I like how fx does dependency injection |
L1ghtman2k
approved these changes
Nov 14, 2022
|
No, not documented. Just manually breaking the ui and fixing it in a branch. I like uber fx approach to dependency injection as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace https://github.com/uber-go/dig with https://github.com/uber-go/fx to string the components together.
Add Procfile to run cockroach, nsq, and server on local machine easier with goreman or any alternative (https://github.com/ddollar/foreman#ports)