Issue fix 43 #46
Issue fix 43 #46
Conversation
|
I still haven't tried this out but I don't feel comfortable with the amount of reformatting and beautification. First, it makes the diff in the pull-request quite hard to read and second I do like the way the imports are formatted and spent quite a lot time making them look nice. |
|
Maybe in future you could split feature/fix and beautifcation into two pull requests. |
|
Anyway, let me get this tried manually today. |
|
This does not work yet, travis produces absolutely weird errors via the request library which I'm unable to reproduce locally (which means it works locally, not just the tests but We'll use another approach to fix this bug. |
|
The import beautifications are done by isort. |
|
Yes, I know about isort, I basically stopped "beautifying" other peoples code after I watched; http://pyvideo.org/video/3511/beyond-pep-8-best-practices-for-beautiful-inte Still the point about splitting beautifcation and bugfix remains. |
Trying to use env with less env variables Use different chars for testing Trying to use bash because of utf-8 Adjusting xargs commandline Let's see what locales we have in cram Try to debug on travis It seem cram is not the culprit Debug on stderr with flush Debugging from the wrong file Debug sys default encoding Log stdin and stdout encoding Changing default stdin/stdout encoding for travis UTF-8 instead of utf-8 Testing direct input parameters Put debug to a different place Test twice differently See if pybuilder's the culprit Digging into pybuilder Putting my pybuilder in a separate line Upgrading pip too Get cram from my fork Exporting PYTHONIOENCODING for cram Debugging further Narrowing down test code Adding a test set export LANG Trying locale-gen Add dpkg-reconfigure Removing locale-gen Add PYTHONIOENCODING Test pybuilder cram plugin Removing debug Cleaning up Adding travis_retry to retry network failed installs Trying to debug yamlreader (pypy3 fails) Force-set exit code from install to 0, stderr -> stdout Don't let travis_retry handle the failing build (test) Removing pypy3, does not build because of yamlreader
|
Will close in favour of #47 |
fixing issue #43, utf8 handling is generally a PITA with py2