-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
@esc ? |
Was in a meeting, sry. |
- pyb install_dependencies | ||
|
||
- travis_retry pip install -U pip | ||
- travis_retry pip install git+https://github.com/karolyi/pybuilder.git cram coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think we need to install cram here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you link me the issue in pybuilder that fixes the cram plugin?
I rebased on current master. |
Sorry, ran into password reset troubles, will continue tomorrow. |
I set myself a new password with an Umlaut and afp-cli was fine, but the I'd like to hold off merging this until it is confirmed to work, of which I am not yet convinced. |
a84db6b
to
338945c
Compare
rewritten, again. only role name parameter can be passed with UTF-8 characters now, which is part of the url, so it gets encoded. |
self.api_url = kwargs.get('api_url', None) | ||
self.ssl_verify = kwargs.get('ssl_verify', True) | ||
|
||
def call_api(self, url_suffix): | ||
"""Send a request to the aws federation proxy""" | ||
url_orig = '{0}{1}'.format(self.api_url, url_suffix) | ||
# Workaround: request seems to mystically fail with utf8 stuff | ||
url = requests.utils.requote_uri(url_orig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this line now, or should we leave it in for good measure? If so, perhaps adapt the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, maybe remove the comment but I'd definitely keep the variable, so it won't have to be compiled at the parameter handover time.
actually there was more that was removed, I just run through the whole source code and removed the non relevant parts, so this is what remained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should definately keep url_orig
.
It looks good, only a few minor nitpicks. Also, we have had some problems with the |
I am the wonderfully reorganized stack of commits from the chaos that emerged with a bad constellation under travis and cram:
aiiie/cram#7
Please merge me, so the world can be a better place.
In other news, I happen to fix 2 bugs at the same time: #42 and #43.