Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for multiple addons using badge #10

Closed
WorldLanguages opened this issue Jul 28, 2020 · 7 comments
Closed

Allow for multiple addons using badge #10

WorldLanguages opened this issue Jul 28, 2020 · 7 comments
Labels
scope: core Related to the core script/extension workings type: enhancement New feature for the project

Comments

@WorldLanguages
Copy link
Member

And we should let users choose what addon can use the badge.
Also, what would happen if the addon the user configured to use the badge got disabled? 🤔
@WorldLanguages WorldLanguages added the type: enhancement New feature for the project label Jul 28, 2020
@Explosion-Scratch

This comment has been minimized.

Sign in to view
@TheColaber
Copy link
Member

What addons would want to use the badge? If disabled, there could be a message in the popup that let's you know.

@Hans5958 Hans5958 added status: needs triage Needs triaging by putting relevant labels scope: core Related to the core script/extension workings and removed status: needs triage Needs triaging by putting relevant labels labels Jan 15, 2021
@williamhorning williamhorning mentioned this issue Apr 5, 2021
Closed
@TheColaber TheColaber mentioned this issue Apr 26, 2021
Open
@lisa-wolfgang
Copy link
Member

When more functionality for the badge does come around, I think it would be more straightforward to have a select type option bar on the message count badge addon and just have that addon get access to the badge, unless we have mutually exclusive addons in the future.

@WorldLanguages
Copy link
Member Author

If another addon wants to use the badge, let's open another issue.

RedGuy12 pushed a commit to RedGuy12/ScratchAddons that referenced this issue Oct 3, 2021
@williamhorning
Merge pull request ScratchAddons#10 from SA-Userscript/wgyt/modular-u…
be40875 
…serscript

Modular userscript
@return-misaPuding
Copy link

Which badge do you mean?

@RedGuy12
Copy link
Contributor

RedGuy12 commented Oct 4, 2021 via email

@CST1229
Copy link
Member

CST1229 commented Oct 4, 2021 •
edited

Maybe possibly allow 2 max badges, one being at the top of the extension icon (the message count always takes that spot if it's enabled), the other being at the bottom.

@WorldLanguages WorldLanguages mentioned this issue Jun 24, 2023
Merged
@supervoidcoder supervoidcoder mentioned this issue Jan 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: core Related to the core script/extension workings type: enhancement New feature for the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@Hans5958 @WorldLanguages @lisa-wolfgang @Explosion-Scratch @RedGuy12 @CST1229 @return-misaPuding @TheColaber