Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it hard for users to mention "scratch addons" in Scratch comments #2089

Closed
WorldLanguages opened this issue Apr 6, 2021 · 25 comments · Fixed by #2212
Closed

Make it hard for users to mention "scratch addons" in Scratch comments #2089

WorldLanguages opened this issue Apr 6, 2021 · 25 comments · Fixed by #2212
Assignees
Labels
scope: core Related to the core script/extension workings type: enhancement New feature for the project
Milestone

Comments

@WorldLanguages
Copy link
Member

WorldLanguages commented Apr 6, 2021

Context
Scratch added "scratch addons" to their comment bad word filter which is fine.
A few weeks ago they started muting new scratchers that commented that.
Now, even 6 y/o accounts get a 5 minute mute for "not following the Community Guidelines".
This modal is clearly confusing and doesn't direct Scratchers to the userscript/extension policy, and fixing it is likely not considered a priority by the Scratch Team.
image

Suggestion

  • If the user is about to post a comment that mentions "scratch addons" (case insensitive), make sure the comment is not actually sent to the Scratch servers yet.
  • Use the same alert format but with our own message (making sure it's clear it's by us, related to Simplify Message by "addon name" from Scratch Addons #1880), telling users their comment was not sent (did not reach Scratch servers), linking them to the userscript/extension policy.
  • That alert should have a small link/button named "send anyway" that can only be clicked after 3 seconds have happened. When clicked, we should trigger a confirm(). It's pretty obvious the user will get muted for 5 minutes, but we don't want to actually prohibit users for doing anything with their account as long as they are aware of the consequences.
@WorldLanguages WorldLanguages added type: enhancement New feature for the project scope: core Related to the core script/extension workings labels Apr 6, 2021
@WorldLanguages WorldLanguages added this to the v1.13.0 milestone Apr 6, 2021
@CubeyTheCube
Copy link

In general how about SA implements their own filter that prevents people from getting muted by not sending the comments to the server if they contain a bad word - not 100% sure if the st will like that though

@cobaltt7
Copy link
Contributor

cobaltt7 commented Apr 6, 2021

Lol, the ST doesn't like anything we do

@WorldLanguages
Copy link
Member Author

I don't think we should maintain a list of muted words. In order to test whether a word is muted we need to try commenting it, and that comment might end up in a moderation queue of some sort, which we don't want to spam.

@retronbv
Copy link
Contributor

retronbv commented Apr 6, 2021

I don't think we should maintain a list of muted words. In order to test whether a word is muted we need to try commenting it, and that comment might end up in a moderation queue of some sort, which we don't want to spam.

Can we somehow find the list?

@mxmou
Copy link
Member

mxmou commented Apr 6, 2021

@retronbv No, the list is private.

@retronbv
Copy link
Contributor

retronbv commented Apr 6, 2021

@retronbv No, the list is private.

I thought someone said something about the list somewhere in the discord

@mxmou
Copy link
Member

mxmou commented Apr 6, 2021

I think we should also do this to "scratchaddons" and "fbeffbjdlemaoicjdapfpikkikjoneco" (the extension ID) to also prevent links - Scratch will likely add those to the blacklist too.

Could this also be done on the forums? Muting doesn't exist there but people could still get an alert.

@CubeyTheCube
Copy link

Scratch uses cleanspeak's api, all we need to do is add a couple of words to the filter, then send the comment to a server before posting, if it's clean then it will be sent. It can't be perfect but it will create 99% less 6 year old rage

@WorldLanguages
Copy link
Member Author

send the comment to a server before posting

bruh no

@CubeyTheCube
Copy link

send the comment to a server before posting

bruh no

oh yeah that might be a bad idea. and storing bad words client side also is. hmmm

@Hans5958
Copy link
Member

Hans5958 commented Apr 7, 2021

In general how about SA implements their own filter that prevents people from getting muted by not sending the comments to the server if they contain a bad word.

This, please. Just implement list of words that we already know it is illegal to do. I don't mind if it's incomplete or some sorts. It's better than nothing.

@WorldLanguages
Copy link
Member Author

Are you sure about including a list of bad words as part of the extension source...?

@TheColaber
Copy link
Member

I think he might have meant the ones for scratch addons but...

@WorldLanguages
Copy link
Member Author

The main goal with this specific issue is giving users context, not making sure they follow the rules. Previously, if you mentioned scratch addons your comment would get reported and/or probably get in a "suspicious comments" moderation queue - and you'd get an alert that would link to the policy. This 5 min mute also affects your account but does not link to the policy, which is important context. We do not need to stop the comment from getting posted to provide context, but it would be weird not to do so.

@WorldLanguages
Copy link
Member Author

lol
image

@jeffalo
Copy link
Contributor

jeffalo commented Apr 7, 2021

lol
image

image

@Hans5958
Copy link
Member

Hans5958 commented Apr 7, 2021

Are you sure about including a list of bad words as part of the extension source...?

Yes. Will there be problems?

And, yes, this is off-topic.

@WorldLanguages
Copy link
Member Author

Yes. Will there be problems?

Probably... not, but who knows? Why risk it...?

@Hans5958
Copy link
Member

Hans5958 commented Apr 8, 2021

Yes. Will there be problems?

Probably... not, but who knows? Why risk it...?

YOLO

@mxmou
Copy link
Member

mxmou commented Apr 8, 2021

And I don't think we need that - the purpose of an extension isn't to prevent users from breaking Scratch rules. The extension policy is an exception because the message Scratch shows is unclear.

@Hans5958
Copy link
Member

Hans5958 commented Apr 8, 2021

@mxmou

And I don't think we need that - the purpose of an extension isn't to prevent users from breaking Scratch rules. The extension policy is an exception because the message Scratch shows is unclear.

Keep in mind that my suggestion is the ones that diverges the main point addresed on the issue.

We're on different sides here. I think having a filter that catches comments with a bad word before it got sent is something I count as feature that empowers the Scratch experience. I sometimes don't know when something is muted or not, so having an addon that catches it first before Scratch catches it would be useful to me.

But, again. This a different addon. I suppose I should create another issue addressing this.

#2104

@WorldLanguages WorldLanguages modified the milestones: v1.13.0, v1.14.0 Apr 16, 2021
@Miala-python
Copy link

On scratch, we can't know what is the word problem.
(Sorry, I don't speak English)

@ghost
Copy link

ghost commented Apr 21, 2021

Why not to create an addon instead of adding filter to the core? It would be easier and more convenient for users (some users may want to disable it).

@WorldLanguages
Copy link
Member Author

@Sly-Little-Fox Users can still post the comment by clicking "Post anyway" then "confirm". Not a big deal.
Keep in mind 99% of times the comment won't get posted anyway because of Scratch's filter (as long as the user didn't find a way to bypass it, but not our filter)

@ghost
Copy link

ghost commented Apr 21, 2021

@Sly-Little-Fox Users can still post the comment by clicking "Post anyway" then "confirm". Not a big deal.
Keep in mind 99% of times the comment won't get posted anyway because of Scratch's filter (as long as the user didn't find a way to bypass it, but not our filter)

Yes, but changing core for it is just weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core Related to the core script/extension workings type: enhancement New feature for the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants