Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Telling the user that there is an update available #73

Closed
BoomerScratch opened this issue Aug 18, 2020 · 15 comments
Closed

[Feature] Telling the user that there is an update available #73

BoomerScratch opened this issue Aug 18, 2020 · 15 comments
Labels
scope: core Related to the core script/extension workings type: enhancement New feature for the project

Comments

@BoomerScratch
Copy link
Contributor

We can use chrome.runtime.getManifest().version to get the current extension version, and then we can fetch the manifest on raw.githubusercontent.com. We can also fetch the CRX file from the chrome web store, extract it and read the manifest.json for more accuracy, but that requires more work and libraries.

If the manifest version doesn't equal, the user will be notified. We need to discuss a way to notify the user. If the user then opens the pop-up (the window that appears when clicking the extension icon), a message will appear saying that there is an update available. It also tells the user how to update the extension.

In the options page, there should also be a switch that disables/enables update notifications (enabled by default) and a number input which allows the user to change the update check interval. (I recommend 1 hour as the default value)

(I know that Chrome updates extensions automatically, but this is just something useful idk)

@BoomerScratch BoomerScratch added the type: enhancement New feature for the project label Aug 18, 2020
@WorldLanguages
Copy link
Member

I don't see the point really, Chrome updates quite often

@easrng
Copy link
Contributor

easrng commented Aug 21, 2020 via email

@WorldLanguages
Copy link
Member

@easrng Can you elaborate "sideloading"?
Also, hi! I don't think I saw you before in the repo? Looks like you have some Scratch related repos, are you interesting on adding them as addons?

@easrng
Copy link
Contributor

easrng commented Aug 21, 2020 via email

@jeffalo
Copy link
Contributor

jeffalo commented Aug 25, 2020

this is very off topic but i think it would be cool if there was like a global notification system so that addons can send notifications and stuff and also maybe once in a while, a notification could be pushed to all users (eg. Version 7 now available, update now) or something

@WorldLanguages
Copy link
Member

@JeffaloBob The addon loader already proxies sent notifications, but at the moment they aren't stored anywhere after being sent. If we implement muting (#9) maybe we can let the user know what notifications they missed?

@GrahamSH-LLK
Copy link
Member

This could be a dev mode only feature. The chrome web store updates too frequently for this to be an issue.

@TheColaber
Copy link
Member

As far as I see, this won't work because of the way we do the system. Very soon, we will bump the version to 1.5.0 on gh, and users would be notified if this were implemented.

@RedGuy12
Copy link
Contributor

RedGuy12 commented Jan 1, 2021

I don't think this is needed. My browser auto-updates.

@TheColaber
Copy link
Member

I don't think this is needed. My browser auto-updates.

This is useful as easrng said,

This is helpful for people sideloading.

@mxmou
Copy link
Member

mxmou commented Jan 2, 2021

I don't think this is needed. My browser auto-updates.

This is useful as easrng said,

This is helpful for people sideloading.

Yes, but it isn't helpful for normal users at all because there is no way to force the browser to update an extension - what's the point of an "update available" message if you can't install it?

@jeffalo
Copy link
Contributor

jeffalo commented Jan 2, 2021

doing git pull every morning isn't that hard

@Hans5958 Hans5958 added status: needs triage Needs triaging by putting relevant labels scope: core Related to the core script/extension workings and removed status: needs triage Needs triaging by putting relevant labels labels Jan 15, 2021
@GrahamSH-LLK
Copy link
Member

Can this be closed?

@WorldLanguages
Copy link
Member

Eh, if we ever provide an official way for Safari users to sideload SA this would be a good addition (since they'd have to update manually pretty much)

@RedGuy12
Copy link
Contributor

RedGuy12 commented Jul 1, 2021

if we ever provide an official way for Safari users to sideload SA this would be a good addition

if we ever

@RedGuy12 RedGuy12 closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core Related to the core script/extension workings type: enhancement New feature for the project
Projects
None yet
Development

No branches or pull requests

9 participants