Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base for Forum Search integration #363

Merged
merged 2 commits into from Oct 1, 2020

Conversation

lholliger
Copy link
Contributor

Changes

Added an addon that adds a search bar to search through forum posts using ScratchDB

image

Reason for changes

There isn't any current site forum search so this implements what some external sites do directly inline on the forums

Tests

Addon is able to search and appears in the addon list properly
image

Notes
I am planning on improving some styling as well as adding sort options such as sorting by newest and oldest in future updates, as well as possibly searching in the category you are currently viewing. I also plan on adding more information about a post instead of just having the username on the left. There is also a few remnants from me debugging still in the code, I will get those removed soon.

image

@GrahamSH-LLK
Copy link
Member

Please go to https://github.com/lholliger/ScratchAddons/actions, and turn on Prettier. Then, do a dummy commit, where you add a space. This will allow Prettier to run.

@WorldLanguages
Copy link
Member

@GrahamSH-LLK I've talked to him, there's a weird Prettier issue that I never went around to try to fix, he did try to run Prettier (locally) tho...

@WorldLanguages WorldLanguages merged commit d8e50f6 into ScratchAddons:master Oct 1, 2020
@lholliger lholliger deleted the search branch October 4, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants