Clickable forum mentions

[Samq64]

Resolves #1445

Changes

Adds a new addon that turns @mentions on the forums into clickable links.

Reason for changes

Clickable links are always nice.

Tests

Tested on Chromium 115. Mentions in BBCode tags don't work right now.

[Secret-chest]

This should be a separate addon, more links is for website

[mxmou]

This should be a separate addon, more links is for website

Forums are a part of the website.

[DNin01]

This should be a separate addon, more links is for website

This new feature does seem to have a pretty different purpose from the addon it's being added to here, plus, curator-link is a separate addon that also makes a username a link. I kind of agree.

[DNin01]

I see this addon differently and I'm not sure it makes sense to add this feature to this addon. This feature might be better off in a new one instead...? This all depends on what we want this addon to be, though. Maybe all of this is better when it's packed into one more general addon, but I'm not sure what to do.

[WorldLanguages]

Blocking merge

[WorldLanguages]

I think this could be a separate addon.
Any objections? @mxmou @Hans5958 @RedGuy12 @Weredime

[Hans5958]

I'm with Samq64's side and thinks that it is better of to keep it as one addon of more-links.

[Hans5958]

In retrospect then we should merge curator-links and put it as a checkbox inside more-links.

[WorldLanguages]

In retrospect then we should merge curator-links and put it as a checkbox inside more-links.

Yeah, if we merge these 3 addons into one, then more-links would need to have 3 checkboxes.

[Hans5958]

Still better in my opinion due to how relatively small the addons are

[Secret-chest]

Remember the better-quoter and forum-quote-beautifier merge idea? They did completely different things to quotes. This does completely different things to links.

[Hans5958]

No?

better-quoter changes how the "Quote" button works, forum-quote-code-beautifier changes how code blocks are styled, a style change.

All more-links, this expansion, and curator-links have something in common: creating links from text that are not linked before, and I fail to see how it "does completely different things to links"

Also, please read #4882 (comment) for my intention related to the name.

[Samq64]

I think this could be a separate addon.

Should I push that then?

outdated

[WorldLanguages]

I believe this PR has some discussion on it about whether this feature should be merged with other addons.

We're probably going to add this as a separate addon, and use the upcoming "related addons"/"see also" functionality so that all addons link to each other.

[DNin01]

We're probably going to add this as a separate addon, and use the upcoming "related addons"/"see also" functionality so that all addons link to each other.

I'm torn on whether to add this to more-links or its own addon, but if we're linking them together, I guess this is fine.

Actually, I think I'm leaning towards a new addon, which is where we are now, but I haven't come up with a final opinion yet. These addons have good reasons to be combined and separate.

[BroJac5246]

We're probably going to add this as a separate addon, and use the upcoming "related addons"/"see also" functionality so that all addons link to each other.

I'm torn on whether to add this to more-links or its own addon, but if we're linking them together, I guess this is fine.

The point of more-links is making more things links, which is what this does. So doesn't it make more sense for it to be part of that?

[DNin01]

We're probably going to add this as a separate addon, and use the upcoming "related addons"/"see also" functionality so that all addons link to each other.

I'm torn on whether to add this to more-links or its own addon, but if we're linking them together, I guess this is fine.

The point of more-links is making more things links, which is what this does. So doesn't it make more sense for it to be part of that?

It's just more-links and this addon have somewhat different use cases, and are the difference between going to an external site and going somewhere else in Scratch.

[BroJac5246]

We're probably going to add this as a separate addon, and use the upcoming "related addons"/"see also" functionality so that all addons link to each other.

I'm torn on whether to add this to more-links or its own addon, but if we're linking them together, I guess this is fine.

The point of more-links is making more things links, which is what this does. So doesn't it make more sense for it to be part of that?

It's just more-links and this addon have somewhat different use cases, and are the difference between going to an external site and going somewhere else in Scratch.

We need a solution for stuff like this because it has come up in the past...

Good point, though, I agree now.

[Hans5958]

It's just more-links and this addon have somewhat different use cases, and are the difference between going to an external site and going somewhere else in Scratch.

In regards to my vision, I don't see making a distiction between external links and internal links reasonable.

The addon converts any URL that are not linked to a linked URL, with no attention to what the URL leads to. Even if, somehow, Scratch makes links of scratch.mit.edu not being linked, it would get caught by the addon nonetheless. This process has no exceptions, in regards to the RegEx pattern.

In case I haven't mentioned it, this baseless distiction would just complicate things more than ever. Why even bother?

[Joeclinton1]

Is there a reason you identified bbcode as an edge case then just didn't solve it? Also perhaps this addon could be made larger into an addon about making all mentions on all parts clickable, following #7301 and #7364.

[Samq64]

Is there a reason you identified bbcode as an edge case then just didn't solve it?

I'll look into it a little later.

Also perhaps this addon could be made larger into an addon about making all mentions on all parts clickable, following #7301 and #7364.

I agree. External links should be one addon and usernames another, but there there's never been a conclusion on that.