April Fools 2024 easter egg: Scratch Haddocks #7299

WorldLanguages · 2024-03-25T18:47:55Z

Right now only the top part of the popup has any changes at all

(THIS SCREENSHOT IS NOW OUTDATED)

WorldLanguages · 2024-03-25T18:49:06Z

libraries/common/global-theme.js

+  const now = Date.now() / 1000;
+  // TODO: update these timestamps for year 2024
+  if (/*now < 1648911600 && now > 1648738800 && */ ["popup"].includes(location.pathname.split("/")[2])) {
+    document.documentElement.style.setProperty("--brand-orange", "#3232fd");


This is not the same blue as the prerelease versions

This is not the same blue as the prerelease versions

Sorry if this is a dumb question that may be a bit off-topic, but, why did you say that in a review on your own PR while you could've just put that in a comment?

mybearworld · 2024-03-25T21:20:56Z

Timestamps for this year are now < 1712070000 && now > 1711897200
Edit: For 12PM GMT: now < 1712059200 && now > 1711886400

DNin01 · 2024-03-25T21:50:53Z

Is there anything else we could replace with emojis of sea creatures? 😁 Maybe some of the icons?

Or could we just have haddocks swimming/floating around on the popup?

DNin01 · 2024-03-26T01:43:02Z

Or could we just have haddocks swimming/floating around on the popup?

Made it:

Scratch.Addons.but.it.s.a.fish.tank.mp4

These are the fish emoji from Windows 11 (the OS I'm using), BTW

DNin01 · 2024-03-26T02:12:49Z

Code for that available at https://github.com/DNin01/ScratchAddons/tree/afd24-fish-tank

@WorldLanguages You can add it to this PR if you want.

WorldLanguages · 2024-03-26T02:17:16Z

Or could we just have haddocks swimming/floating around on the popup?

lol! I don't know what to think

WorldLanguages · 2024-03-26T02:21:01Z

Timestamps for this year are now < 1712070000 && now > 1711897200

I'm not sure if those are 3 hours off or not? Time zones make it confusing
My intention was always to make our April Fools be from March 31 noon UTC+0 to April 2 noon UTC+0

mybearworld · 2024-03-26T09:05:24Z

They're the same as 2022 for me - so 3PM GMT, not 12pm.

These should be 12pm GMT: now < 1712059200 && now > 1711886400

Waakul · 2024-03-26T13:22:44Z

Timestamps for this year are now < 1712070000 && now > 1711897200

I'm not sure if those are 3 hours off or not? Time zones make it confusing My intention was always to make our April Fools be from March 31 noon UTC+0 to April 2 noon UTC+0

Why use timestamps?

var currentDate = new Date();

var currentMonth = currentDate.getMonth();
var currentDay = currentDate.getDate();

if ((currentMonth === 2 && currentDay >= 31) || (currentMonth === 3 && currentDay <= 2)) {
    // The code to do when the date is march 31st - April 2nd here.
}

Can do the trick..

mybearworld · 2024-03-26T13:33:03Z

I think we want it to appear at the same time for all users. Timestamps ignore time zones, your code doesn't.

Waakul · 2024-03-26T14:39:49Z

currentMonth === 2 && currentDay >= 31

~~February 31st, what a leap year!~~

Months start from 0 in js if you're confused.

CST1229 · 2024-03-26T15:21:44Z

Months start from 0 in js if you're confused.

And days don't?!

mybearworld · 2024-03-26T15:24:25Z

And days don't?!

Welcome to JavaScript!

WorldLanguages · 2024-03-26T15:48:25Z

Or could we just have haddocks swimming/floating around on the popup?

Made it:

Should we add those then? As long as they aren't that annoying, it should be fine...

EDIT: I added the swimming fish to this PR.

WorldLanguages · 2024-03-26T15:50:28Z

(We wouldn't show the fish animations if reduced-motion was toggled by the user)

BroJac5246 · 2024-03-26T15:58:29Z

I propose that we also temporarily replace the dangos with haddocks because it's easy and why not?

WorldLanguages · 2024-03-26T15:59:39Z

I propose that we also temporarily replace the dangos with haddocks because it's easy and why not?

Replace which dangos?

Waakul · 2024-03-26T16:00:51Z

If we could collect some projects related to haddocks, we could feature them in a separate section under the featured projects section in the homepage like featured dangos?

mybearworld · 2024-03-26T16:00:59Z

Replace which dangos?

Probably in dango-rain

mybearworld · 2024-03-26T16:03:10Z

If we could collect some projects related to haddocks, we could feature them in a separate section under the featured projects section in the homepage like featured dangos?

Meh, not sure if we want to reuse that
I'd be very surprised if there are actual good projects about haddocks lol

WorldLanguages · 2024-03-26T16:12:09Z

What shade of blue is best to represent fish?

EDIT: I changed it to "Bluetiful" #3C69E7 because it is a lighter blue but it still has enough contrast with white text.

Waakul · 2024-03-26T16:13:39Z

What shade of blue is better to represent fish?

Aqua blue in my opinion.

DNin01 · 2024-03-27T20:11:36Z

Okay, the haddocks shouldn't swim through the edges anymore.

RedGuy12 · 2024-03-28T16:49:27Z

Are we still planning to merge this and release 1.37, and expecting CWS to review this before Monday? There's not much time...

WorldLanguages · 2024-03-28T18:35:54Z

Looks ready to merge @DNin01 @Samq64 @mybearworld Any approvals?

To test it you can replace the 4 instances of const now = Date.now() / 1000; with const now = 1711886401;

WorldLanguages · 2024-03-28T18:37:11Z

I also tested this with reduced motion enabled.

mybearworld

The contrast of the fish in the header (when prefers-reduced-motion is enabled) isn't great on Windows 11, but that's not that important.

Waakul · 2024-03-28T20:18:46Z

The logo is'nt changed yet...

mybearworld · 2024-03-28T20:21:00Z

I might be wrong on this, but changing the logo would probably delay the process of getting this approved on the web stores further.

Waakul · 2024-03-28T20:28:35Z

I updated my haddocks logo a bit so the icon is visible
EDIT: updated again

mybearworld · 2024-03-28T20:34:57Z

I might be wrong on this, but changing the logo would probably delay the process of getting this approved on the web stores further.

Also, changing the logo dynamically only on April Fools sounds like a headache...

Waakul · 2024-03-28T20:36:45Z

I might be wrong on this, but changing the logo would probably delay the process of getting this approved on the web stores further.

Also, changing the logo dynamically only on April Fools sounds like a headache...

By logo i only meant on the popup. See WorldLanguages#5

WorldLanguages · 2024-03-28T21:44:40Z

Reviews within 1 hour please

Samq64

Tested on Firefox

DNin01

LGTM

mybearworld · 2024-03-31T22:38:16Z

These haddocks can be kind of obtrusive when reading or writing comments, though.

I don't know, maybe we could hide them or make them transparent while you're writing a comment.

That probably should've been implemented - these haddocks are actually pretty annoying when trying to write a comment.

DNin01 · 2024-03-31T22:53:01Z

These haddocks can be kind of obtrusive when reading or writing comments, though.
I don't know, maybe we could hide them or make them transparent while you're writing a comment.

That probably should've been implemented - these haddocks are actually pretty annoying when trying to write a comment.

Yup...

The good things are:

You can always open the comment on Scratch.
You can also click the small little icon on the Messaging tab to open the whole Messaging popup in a new tab, which doesn't have haddocks swimming around. Not sure how many people will realize that, though...
You could also use a text editor to write your comment without distractions, then paste it in, I suppose.

This reverts commit 643fca2.

Revert "April Fools 2024 easter egg: Scratch Haddocks (#7299)" This reverts commit 643fca2.

Scratch Haddocks

c4d93f7

WorldLanguages requested a review from apple502j as a code owner March 25, 2024 18:47

WorldLanguages mentioned this pull request Mar 25, 2024

What to do for April Fools 2024? #7295

Closed

WorldLanguages commented Mar 25, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

Samq64 added type: enhancement New feature for the project scope: webpages Related to the web pages (settings page, pop-up, etc) labels Mar 26, 2024

Samq64 added this to the v1.37.0 milestone Mar 26, 2024

WorldLanguages mentioned this pull request Mar 26, 2024

very boring PR #7217

Closed

Make sure they don't move offscreen

3adfcb5

Fish emojis in name if reduced motion preferred

12cfc81

WorldLanguages added 6 commits March 28, 2024 15:26

Use 2024 timestamps (thanks mybearworld)

a95bccd

Add missing date check

4e77c56

Add fish after 100ms and fix bug

5b67085

Prettier lint

14da957

Not enough time to fix language TODO

cc5a67e

Need to divide date by 1000

b2dbc40

mybearworld approved these changes Mar 28, 2024

View reviewed changes

DNin01 self-requested a review March 28, 2024 21:42

Samq64 approved these changes Mar 28, 2024

View reviewed changes

DNin01 approved these changes Mar 28, 2024

View reviewed changes

WorldLanguages changed the title ~~Scratch Haddocks~~ April Fools 2024 easter egg: Scratch Haddocks Mar 28, 2024

WorldLanguages merged commit 643fca2 into ScratchAddons:master Mar 28, 2024
2 checks passed

Samq64 mentioned this pull request Mar 28, 2024

Disable some addons for April Fools #7308

Merged

WorldLanguages added a commit that referenced this pull request Apr 2, 2024

Revert "April Fools 2024 easter egg: Scratch Haddocks (#7299)"

90b23fc

This reverts commit 643fca2.

WorldLanguages mentioned this pull request Apr 2, 2024

Revert "April Fools 2024 easter egg: Scratch Haddocks" #7327

Merged

WorldLanguages added a commit that referenced this pull request Apr 2, 2024

Revert "April Fools 2024 easter egg: Scratch Haddocks" (#7327)

129941c

Revert "April Fools 2024 easter egg: Scratch Haddocks (#7299)" This reverts commit 643fca2.

April Fools 2024 easter egg: Scratch Haddocks #7299

April Fools 2024 easter egg: Scratch Haddocks #7299

Conversation

WorldLanguages commented Mar 25, 2024 • edited Loading

WorldLanguages Mar 25, 2024

Choose a reason for hiding this comment

OneShot-Niko Mar 25, 2024

Choose a reason for hiding this comment

mybearworld commented Mar 25, 2024 • edited Loading

DNin01 commented Mar 25, 2024

DNin01 commented Mar 26, 2024

DNin01 commented Mar 26, 2024

WorldLanguages commented Mar 26, 2024

WorldLanguages commented Mar 26, 2024

mybearworld commented Mar 26, 2024 • edited Loading

Waakul commented Mar 26, 2024

mybearworld commented Mar 26, 2024

This comment was marked as resolved.

Waakul commented Mar 26, 2024 • edited Loading

CST1229 commented Mar 26, 2024

mybearworld commented Mar 26, 2024

WorldLanguages commented Mar 26, 2024 • edited Loading

WorldLanguages commented Mar 26, 2024

BroJac5246 commented Mar 26, 2024

WorldLanguages commented Mar 26, 2024

Waakul commented Mar 26, 2024

mybearworld commented Mar 26, 2024

mybearworld commented Mar 26, 2024

WorldLanguages commented Mar 26, 2024 • edited Loading

Waakul commented Mar 26, 2024

DNin01 commented Mar 27, 2024

RedGuy12 commented Mar 28, 2024

WorldLanguages commented Mar 28, 2024

WorldLanguages commented Mar 28, 2024

mybearworld left a comment

Choose a reason for hiding this comment

Waakul commented Mar 28, 2024

mybearworld commented Mar 28, 2024

Waakul commented Mar 28, 2024 • edited Loading

mybearworld commented Mar 28, 2024

Waakul commented Mar 28, 2024

WorldLanguages commented Mar 28, 2024

Samq64 left a comment

Choose a reason for hiding this comment

DNin01 left a comment

Choose a reason for hiding this comment

mybearworld commented Mar 31, 2024

DNin01 commented Mar 31, 2024

WorldLanguages commented Mar 25, 2024 •

edited

Loading

mybearworld commented Mar 25, 2024 •

edited

Loading

mybearworld commented Mar 26, 2024 •

edited

Loading

Waakul commented Mar 26, 2024 •

edited

Loading

WorldLanguages commented Mar 26, 2024 •

edited

Loading

WorldLanguages commented Mar 26, 2024 •

edited

Loading

Waakul commented Mar 28, 2024 •

edited

Loading