-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Addon: Timing Blocks and Line-By-Line Profiling for Debugger #7443
base: master
Are you sure you want to change the base?
Conversation
We could maybe move the timing data into the Performance tab, if necessary. There might not be enough space to fit four tabs in some languages…? |
It would just be cluttered. the performance tab has these graphs. you'd need to put them above or below the timers which makes them less easy to use. To remedy that you need a second level set of tabs and things get annoying quickly. I made the window wider by the width of the word timers. Technically yes it's not going to fit. perhaps we can resize the whole window if it doesn't fit dynamically with js. Maybe a burger menu, could automatically enable when it runs out space, and the 4 tabs become a dropdown or side menu? We could also ask translators to pick between the translation of profiler, profiling, timer and timing, for whichever is shortest. |
Resolves #7418
Changes
This is the biggest addon I've made to date. It adds:
Reason for changes
See #7418
Tests
The functionality described in Changes has been tested and works.
Remaining stuff: