Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive permissions page #7482

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Samq64
Copy link
Member

@Samq64 Samq64 commented May 31, 2024

Resolves #6844
Resolves #7464 (comment)

Changes

Makes the permissions page responsive, adds a scrollbar and fixes the button text.

Reason for changes

The permissions page was not designed for phones or short screens.

Tests

Tested on Chromium. Since I didn't put the scrollbar on the body it won't necessarily be on the edge of the window. The image is also slightly too wide for the IPhone SE in devtools.

@Samq64 Samq64 added scope: webpages Related to the web pages (settings page, pop-up, etc) scope: accessibility Addresses an accessibility issue platform: mobile Related to compatibility with touch screen devices labels May 31, 2024
Copy link
Member

@mxmou mxmou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is also slightly too wide for the IPhone SE in devtools.

This can be fixed by changing

#screenshot {
  height: 10rem;
}

to

#screenshot {
  width: 24rem;
  max-width: 100%;
}

webpages/settings/style.css Outdated Show resolved Hide resolved
webpages/settings/style.css Outdated Show resolved Hide resolved
webpages/settings/style.css Outdated Show resolved Hide resolved
Co-Authored-By: Maximouse <51849865+mxmou@users.noreply.github.com>
@mxmou mxmou added the status: needs review [Use when there's already 1 approval] Review needed on the PR label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: mobile Related to compatibility with touch screen devices scope: accessibility Addresses an accessibility issue scope: webpages Related to the web pages (settings page, pop-up, etc) status: needs review [Use when there's already 1 approval] Review needed on the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

button label on permissions page not centered
2 participants