-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive permissions page #7482
Open
Samq64
wants to merge
5
commits into
ScratchAddons:master
Choose a base branch
from
Samq64:responsive-permissions-page
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmou
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is also slightly too wide for the IPhone SE in devtools.
This can be fixed by changing
#screenshot {
height: 10rem;
}
to
#screenshot {
width: 24rem;
max-width: 100%;
}
Co-Authored-By: Maximouse <51849865+mxmou@users.noreply.github.com>
mxmou
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform: mobile
Related to compatibility with touch screen devices
scope: accessibility
Addresses an accessibility issue
scope: webpages
Related to the web pages (settings page, pop-up, etc)
status: needs review
[Use when there's already 1 approval] Review needed on the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6844
Resolves #7464 (comment)
Changes
Makes the permissions page responsive, adds a scrollbar and fixes the button text.
Reason for changes
The permissions page was not designed for phones or short screens.
Tests
Tested on Chromium. Since I didn't put the scrollbar on the body it won't necessarily be on the edge of the window. The image is also slightly too wide for the IPhone SE in devtools.