Fixed Cut converter raising index out of bounds error and added CutTest.

Fixed DualConverter::convertCollection not accepting arrays.
Added Coveralls support to Travis settings.
Added architecture diagram to README.
Reorganized tests into test type directories.

.travis.yml

@@ -5,11 +5,15 @@ php:
   - 5.6
 
 install:
-  - composer --no-interaction install
+  - composer -n require satooshi/php-coveralls:dev-master
 
 script:
-  - vendor/bin/phpunit --coverage-clover=clover.xml test
+  - vendor/bin/phpunit --coverage-clover=build/logs/clover.xml test
 
 after_script:
+  # Scrutinizer coverage.
   - wget http://scrutinizer-ci.com/ocular.phar
-  - php ocular.phar code-coverage:upload --format=php-clover clover.xml
+  - php ocular.phar code-coverage:upload --format=php-clover build/logs/clover.xml
+
+  # Coveralls coverage.
+  - vendor/bin/coveralls

README.md

@@ -1,17 +1,21 @@
 Open Dash
 =========
 
-![Version][Version image]
+[![Version][Version image]]()
 [![Build Status][Build image]][Build]
 [![Code Coverage][Coverage image]][Coverage]
 [![Scrutinizer Code Quality][Quality image]][Quality]
 
 Open source Web-based dashboard for Unix systems.
 
+Architecture
+------------
+![Diagram](https://raw.githubusercontent.com/ScriptFUSION/Open-Dash/master/diagrams/Open%20Dash.png)
+
   [Version image]: http://img.shields.io/github/tag/ScriptFUSION/Open-Dash.svg "Latest version"
   [Build]: http://travis-ci.org/ScriptFUSION/Open-Dash
-  [Build image]: http://img.shields.io/travis/ScriptFUSION/Open-Dash.svg
-  [Coverage]: https://scrutinizer-ci.com/g/ScriptFUSION/Open-Dash/?branch=master
-  [Coverage image]: https://scrutinizer-ci.com/g/ScriptFUSION/Open-Dash/badges/coverage.png?b=master "Code coverage"
+  [Build image]: http://img.shields.io/travis/ScriptFUSION/Open-Dash.svg "Build status"
+  [Coverage]: https://coveralls.io/r/ScriptFUSION/Open-Dash
+  [Coverage image]: https://img.shields.io/coveralls/ScriptFUSION/Open-Dash.svg "Code coverage"
   [Quality]: https://scrutinizer-ci.com/g/ScriptFUSION/Open-Dash/?branch=master
   [Quality image]: https://scrutinizer-ci.com/g/ScriptFUSION/Open-Dash/badges/quality-score.png?b=master "Code quality"

src/Convert/Cut.php

@@ -19,6 +19,12 @@ public function __construct($fields, $delimiter = "\t") {
      * @return string
      */
     public function convertString($string) {
-        return explode($this->delimiter, $string)[$this->fields - 1];
+        $parts = explode($this->delimiter, $string);
+        $field = $this->fields - 1;
+
+        if (isset($parts[$field]))
+            return $parts[$field];
+
+        return '';
     }
 }

src/Convert/DualConverter.php

@@ -25,10 +25,10 @@ public function convert($data) {
     abstract public function convertString($string);
 
     /**
-     * @param \Traversable $items
+     * @param \Traversable|array $items
      * @return \Iterator
      */
-    public function convertCollection(\Traversable $items) {
+    public function convertCollection($items) {
         return \iter\map([$this, 'convertString'], $items);
     }
 }

src/DataProvider/DataProvider.php

@@ -1,6 +1,8 @@
 <?php
 namespace ScriptFUSION\OpenDash\DataProvider;
 
+use ScriptFUSION\OpenDash\Data\Data;
+
 /**
  * Defines a mechanism for providing data.
  */

test/unit/ApacheVersionTest.php → test/integration/ApacheVersionTest.php

@@ -3,7 +3,8 @@
 use ScriptFUSION\OpenDash\DataProvider\System\ApacheVersion;
 
 class ApacheVersionTest extends PHPUnit_Framework_TestCase {
-    public function testFilters() {
+    public function testConverters() {
+        /** @var ApacheVersion $apacheVersion */
         $apacheVersion = Mockery::mock(ApacheVersion::class, [])->makePartial()->shouldReceive(
             ['execute' => new SystemData(
                 "Server version: Apache/1.2.34 (Unix)\nServer built:   Jan 01 1970 00:00:00\n"

test/unit/FilterChainTest.php → test/unit/ConversionChainTest.php

@@ -1,8 +1,8 @@
 <?php
 use ScriptFUSION\OpenDash\Convert\ConversionChain;
 
-class FilterChainTest extends PHPUnit_Framework_TestCase {
-    public function testFilterChain() {
+class ConversionChainTest extends PHPUnit_Framework_TestCase {
+    public function testConvert() {
         $chain = (new ConversionChain)->addConverters([
             function() { return 'foo'; },
             function($data) { return "${data}bar"; }

test/unit/CutTest.php

@@ -0,0 +1,21 @@
+<?php
+use ScriptFUSION\OpenDash\Convert\Cut;
+
+class CutTest extends PHPUnit_Framework_TestCase {
+    /** @dataProvider provideData */
+    public function test($data, $fields, $delimiter, $result) {
+        $this->assertSame($result, (new Cut($fields, $delimiter))->convert($data));
+    }
+
+    public function provideData() {
+        return [
+            ["foo\tbar", 0, "\t", ''],
+            ["foo\tbar", 1, "\t", 'foo'],
+            ["foo\tbar", 2, "\t", 'bar'],
+            ["foo\tbar", 3, "\t", ''],
+            ['foo  bar', 1, ' ', 'foo'],
+            ['foo  bar', 2, ' ', ''],
+            ['foo  bar', 3, ' ', 'bar'],
+        ];
+    }
+}