-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neoletter | Form Builder | Subscription as a hidden field #542
base: master
Are you sure you want to change the base?
Neoletter | Form Builder | Subscription as a hidden field #542
Conversation
…idden field widget
…ld in the hidden field widget
👷 Deploy request for scrivito-example pending review.Visit the deploys page to approve it
|
FYI: I will not be able to review this PR in the near future. My queue is quite full with high priority tasks. |
Would be cool, if we could get this merged 😎 |
As far as I know Amier is working on an NPM package to incorporate the form builder. To me this would be the right place to add such functionality. |
I adapted it to the Scrivito-Neoletter-Form-Widgets package and also reviewed it. The code appears to be in good shape, so perhaps you could approve it easily? Or perhaps someone else from your team could review it as well? I'm willing to take responsibility if any issues arise. The situation is that there are existing customers who want that feature but aren't currently using the package. They've made some modifications to their form widgets that might not function properly if they switch to using the package. |
@aea-JR : Thank you for your offer. But I think it would be useful if:
Could you create a PR that removes the existing form widgets from the example app and use |
Related to #535
To make the subscription process more straightforward, we've made a change in the Form Builder. Previously, users had to actively check a specific checkbox to subscribe. We realized this step might not be necessary for all types of subscription forms. To simplify the process, we've incorporated the subscription action as a hidden field within the form. This means that when users fill out the form, the subscription process is initiated without the need for the user to check an additional checkbox.
Currently, subscription feature-related fields are activated when the ENABLE_NEOLETTER_FORM_BUILDER_SUBSCRIPTION_FEATURE environment variable flag is set.
Without flag:
![Screenshot 2023-08-21 at 14 27 35](https://private-user-images.githubusercontent.com/31543263/262024979-6fe04326-389e-44a5-96b8-afb39f499ad6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwNTcxOTYsIm5iZiI6MTcxOTA1Njg5NiwicGF0aCI6Ii8zMTU0MzI2My8yNjIwMjQ5NzktNmZlMDQzMjYtMzg5ZS00NGE1LTk2YjgtYWZiMzlmNDk5YWQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIyVDExNDgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk5MzhmODc1ZDM3MmZmZjhkZTFmY2YzODUyOTBhYWViNjcxYjZlYzY3NWJmZWZhZmQ3ZTNmOGM1NjJjNzg0YTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.N26QL29669M_qH11DQG4auRikrOmR72Jc0kPU1yARok)
With flag:
![Screenshot 2023-08-21 at 14 13 54](https://private-user-images.githubusercontent.com/31543263/262025029-7cc6c4af-fdaa-4c40-b082-956c22a6894b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwNTcxOTYsIm5iZiI6MTcxOTA1Njg5NiwicGF0aCI6Ii8zMTU0MzI2My8yNjIwMjUwMjktN2NjNmM0YWYtZmRhYS00YzQwLWIwODItOTU2YzIyYTY4OTRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIyVDExNDgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmYTU4Yjk5MDcyZDcxM2UwN2YzNjg1NjM4NzAxZTE4NDFhODgzY2ZmZTM2YjNmYTNjNmUxNjdlY2NkZGQ0MmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.U04_sGHn0AiHg9ZCLetkFpK8fG4shnSitBSQYrOjphA)
![Screenshot 2023-08-21 at 14 13 59](https://private-user-images.githubusercontent.com/31543263/262025049-e9dbcf78-0a1e-493f-804e-71cc1406e887.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwNTcxOTYsIm5iZiI6MTcxOTA1Njg5NiwicGF0aCI6Ii8zMTU0MzI2My8yNjIwMjUwNDktZTlkYmNmNzgtMGExZS00OTNmLTgwNGUtNzFjYzE0MDZlODg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIyVDExNDgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE4ODNiOTYxMWUxMjhmMjY5YWIwY2FjYzU4MDNjOThhNDBkM2VlZjk3MmM1M2ViZjcyYjg3ZWU3Yjk2NDZmNGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Qgq_QQxldXW8IGZxvJBtI0HKnG4gFdduuwocEfy0BnA)
![Screenshot 2023-08-21 at 14 14 10](https://private-user-images.githubusercontent.com/31543263/262025076-2183c5e5-4502-4616-87f9-1a80efaf037d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkwNTcxOTYsIm5iZiI6MTcxOTA1Njg5NiwicGF0aCI6Ii8zMTU0MzI2My8yNjIwMjUwNzYtMjE4M2M1ZTUtNDUwMi00NjE2LTg3ZjktMWE4MGVmYWYwMzdkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjIyVDExNDgxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE0YTNkNjYyYmViMGU0YzJjNDRmZGYxNzY1YzdjYjk4MWMxNDlkNGI4MzM4NWI5MjE1MzRiYzg5YTI3ZGE1YzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.3W59E0tGSyAgCCdEDxh0vQgkGEWlnl4ckck2jyxmPGg)